Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-env]: Hotfix mysql 8.4 being incompatible due to auth plugin deprecation #1803

Merged
merged 4 commits into from
May 1, 2024

Conversation

rinatkhaziev
Copy link
Contributor

@rinatkhaziev rinatkhaziev commented May 1, 2024

Description

This PR locks MySQL at 8.4 because it's impossible to downgrade once upgraded from 8.3 => 8.4.

8.4 dropped the mysql_native_password plugin which we currently need, in order to get it back a new flag is introduced and the old one is removed.

So this PR removes the old --default-authentication-plugin=mysql_native_password and adds new --mysql-native-password=ON

Dev Env version is bumped to 2.0.3 so on the next start the migration routine will upgrade the Lando file accordingly.

Pull request checklist

New release checklist

Steps to Test

Outline the steps to test and verify the PR here.

Example:

  1. Check out PR.
  2. Run npm run build
  3. Run ./dist/bin/vip-cookies.js nom
  4. Verify cookies are delicious.

Copy link
Contributor

github-actions bot commented May 1, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

sonarcloud bot commented May 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

@mhsdef mhsdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests green.

(Didn't test)

@rinatkhaziev rinatkhaziev merged commit 941e86f into trunk May 1, 2024
18 checks passed
@rinatkhaziev rinatkhaziev deleted the hotfix/dev-env-mysql-8.4-incompat branch May 1, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants