Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused, deprecated functions #1088

Merged
merged 1 commit into from
Jan 31, 2019
Merged

Remove unused, deprecated functions #1088

merged 1 commit into from
Jan 31, 2019

Conversation

joshbetz
Copy link
Contributor

These functions have been deprecated on VIP Go and are currently unused
by any VIP Go sites. We'll move this code to the vip-go-wpcom-compat
plugin so sites that are moving from WordPress.com are safe, but this
code is not loaded on the rest of VIP Go sites.

@joshbetz
Remove unused, deprecated functions
788d692 
These functions have been deprecated on VIP Go and are currently unused
by any VIP Go sites. We'll move this code to the vip-go-wpcom-compat
plugin so sites that are moving from WordPress.com are safe, but this
code is not loaded on the rest of VIP Go sites.
joshbetz added a commit to Automattic/vip-go-wpcom-compat that referenced this pull request Jan 25, 2019
@joshbetz
Add deprecated functions that are currently unused on VIP Go
566d773 
This moves some deprecated functions from vip-go-mu-plugins. These are
currently unused on VIP Go, but may be used by other sites that are
moving from WordPress.com to VIP Go.

Related: Automattic/vip-go-mu-plugins#1088
@joshbetz joshbetz mentioned this pull request Jan 25, 2019
Closed
@joshbetz
Copy link
Contributor Author

The next step will be removing all the functions that currently don't do anything other than throw deprecation warnings and don't even return anything.

wpcom_vip_load_helper
wpcom_vip_load_helper_wpcom
wpcom_vip_load_helper_stats
vip_allow_title_orphans
wpcom_vip_disable_enhanced_feeds
vip_remove_enhanced_feed_images
make_tags_local
wpcom_vip_allow_full_size_images_for_real
wpcom_vip_remove_polldaddy_rating
wpcom_vip_disable_postpost
wpcom_vip_enable_opengraph
wpcom_disable_mobile_app_promotion
wpcom_vip_allow_more_html_in_comments
wpcom_vip_disable_devicepx_js
wpcom_vip_disable_hovercards
wpcom_vip_disable_custom_customizer
wpcom_vip_remove_opensearch
vary_cache_on_function
disable_autosave
vip_multiple_moderators
wpcom_vip_disable_zemanta_for_all_users
wpcom_vip_disable_smilies
wpcom_vip_stats_roles
wpcom_print_sitemap_item
wpcom_print_xml_tag
wpcom_print_sitemap
wpcom_print_news_sitemap
do_sitemap_pings
sitemap_discovery
sitemap_handle_update
wpcom_vip_remove_feed_tracking_bug
wpcom_vip_plugins_ui_disable_activation
wpcom_vip_load_custom_cdn
wpcom_vip_remove_playlist_styles
wpcom_vip_disable_instapost

mjangda
mjangda approved these changes Jan 26, 2019
View reviewed changes
Copy link
Member

@mjangda mjangda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hanifn hanifn merged commit df5b3a1 into master Jan 31, 2019
@hanifn hanifn deleted the rm/unused-deprecated-functions branch January 31, 2019 08:13
@hanifn
Copy link
Contributor

hanifn commented Jan 31, 2019

r128977-deploy

@hanifn
Copy link
Contributor

hanifn commented Jan 31, 2019 •
edited by mjangda

Reverted in 2e8c1d4 and r128978-deploy

500 Internal Server Error for many sites on Nagios

@hanifn
Copy link
Contributor

hanifn commented Jan 31, 2019 •
edited

Found in logs: Uncaught Error: Call to undefined function _wpcom_vip_load_plugin_sanitizer()

Looks like some functions were still in use

hanifn added a commit that referenced this pull request Jan 31, 2019
@hanifn
Revert "Merge pull request #1088 from Automattic/rm/unused-deprecated…
2e8c1d4 
…-functions"

This reverts commit df5b3a1, reversing
changes made to 1de234a.
@mjangda
Copy link
Member

mjangda commented Feb 1, 2019

We'll want to take another pass at this but with a few changes:

  • Start with logging only changes to confirm that the function are not actually in use.
  • Reduce the size a bit, preferably one function at a time (which will take longer but is safer).
  • Add some tests for the wpcom_vip_load_plugin function.
  • We're also looking at more thorough integration and pre-deploy tests internally.

@joshbetz joshbetz restored the rm/unused-deprecated-functions branch February 1, 2019 14:23
@joshbetz joshbetz deleted the rm/unused-deprecated-functions branch February 1, 2019 14:24
@joshbetz joshbetz restored the rm/unused-deprecated-functions branch February 1, 2019 14:24
@joshbetz joshbetz mentioned this pull request Feb 1, 2019
Closed
@joshbetz
Copy link
Contributor Author

joshbetz commented Feb 1, 2019

Found in logs: Uncaught Error: Call to undefined function _wpcom_vip_load_plugin_sanitizer()
Looks like some functions were still in use

😬 we still use this within mu-plugins. Opened #1095 to move that out of vip-deprecated.php.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjangda mjangda mjangda approved these changes

Assignees
No one assigned
Labels
[Status] Reverted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joshbetz @hanifn @mjangda