Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set wp-parsely 3.6 as the default version #4037

Merged
merged 3 commits into from Jan 10, 2023

Conversation

acicovic
Copy link
Contributor

Description

This PR sets wp-parsely 3.6 as the default version in vip-go-mu-plugins. Any users who are not pinned to a specific wp-parsely version will automatically be upgraded to 3.6.x when this PR takes effect.

Changelog Description

wp-parsely default version was upgraded to 3.6

Changed the default version of wp-parsely from 3.5 to 3.6.

Checklist

Please make sure the items below have been covered before requesting a review:

  • This change works and has been tested locally (or has an appropriate fallback).
  • This change works and has been tested on a Go sandbox.
  • This change has relevant unit tests (if applicable).
  • This change has relevant documentation additions / updates (if applicable).
  • I've created a changelog description that aligns with the provided examples.

Steps to Test

  1. Checkout the PR.
  2. Enable wp-parsely:
add_filter( 'wpvip_parsely_load_mu', '__return_true' );
  1. In wp-admin, go the plugin's settings (Settings -> Parse.ly). On the top of the page, you should be seeing the new default version number (3.6.x).

@acicovic acicovic requested a review from a team as a code owner January 10, 2023 18:18
@acicovic acicovic self-assigned this Jan 10, 2023
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #4037 (f09dc53) into develop (d035d93) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head f09dc53 differs from pull request most recent head b19d297. Consider uploading reports for the commit b19d297 to get more accurate results

@@            Coverage Diff             @@
##             develop    #4037   +/-   ##
==========================================
  Coverage      32.23%   32.24%           
+ Complexity      3789     3787    -2     
==========================================
  Files            229      229           
  Lines          16889    16888    -1     
==========================================
+ Hits            5445     5446    +1     
+ Misses         11444    11442    -2     
Impacted Files Coverage Δ
wp-parsely.php 43.95% <ø> (ø)
search/includes/classes/class-versioning.php 86.40% <0.00%> (+0.42%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Jan 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants