Search: Fix potential prolonged rate-limiting #5524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct didn't have an expiration which may prevent the ratelimit window reset
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5524 +/- ##
=============================================
+ Coverage 28.77% 28.80% +0.03%
Complexity 4844 4844
=============================================
Files 284 284
Lines 21017 21010 -7
=============================================
+ Hits 6047 6052 +5
+ Misses 14970 14958 -12 ☔ View full report in Codecov by Sentry. |
WPprodigy
reviewed
Apr 30, 2024
WPprodigy
reviewed
Apr 30, 2024
|
rinatkhaziev
changed the title
WPprodigy
approved these changes
Apr 30, 2024
sjinks
added a commit
that referenced
this pull request
May 7, 2024
* Exclude versioned Jetpacks from the `-built` version. (#5496) * Don't delete jetpack-* recursively, do the root only. Supply --delete-excluded flag (#5498) * CI: Preserve the .git folder when running --delete-excluded (#5500) * Don't delete jetpack-* recursively, do the root only. Supply --delete-excluded flag * Preserve .git * Use full path * Add debug to rsync output in Deploy workflow (#5501) * Move backup one folder up to prevent the deletion during the rsync (#5502) * Add debug to rsync output in Deploy workflow * Move .git backup one level up * Remove debug info from Deploy action (#5503) * fix: `count_users()` returns an array (#5499) * fix: `count_users()` returns an array * test: fix tests * CI: set minimum Parse.ly version to 3.5 (#5506) * CI: update Parse.ly minimum version, fix some typos * Remove debug-bar and debug-bar-cron as they're not the part of mu-plugins * Add the ability to define a custom VIP integrations config directory (#5505) * Search: Defaults Enterprise Search to ElasticPress 4.2.2 (#4607) * Search: Remove exception list * Search: Switch to new EP as default * Sync changes down * Update submodule change to latest one * Update the PR template to include the new Changelog format (#5477) * Remove limitation on "wp db size" (#5507) * Revert "Remove limitation on "wp db size" (#5507)" (#5522) This reverts commit 2efcab4. Revert "Remove limitation on "wp db size" (#5507)" This reverts commit 720c8b9. * Search: Fix potential prolonged rate-limiting (#5524) * Fix potential prolonged rate-limiting: the rate-limit start time object didn't have an expiration which may prevent the ratelimit window reset * Fix context * Apply settings on after_setup_theme to make sure customer code is included * Only consider requests in current window when enabling ratelimiting * Address feedback * Apply SonarCloud suggestions * remove ttl for indexing ratelimit start. More static over self. --------- Co-authored-by: Rinat K <rinat@automattic.com> Co-authored-by: Volodymyr Kolesnykov <volodymyr.kolesnykov@automattic.com> Co-authored-by: Luis Henrique Mulinari <luis.henrique.mulinari@automattic.com> Co-authored-by: Luiz Tiago Oliveira <luiztiago@gmail.com>
github-actions
bot
added
[Status] Deployed to production
and removed
[Status] Deployed to staging
labels
sjinks
added a commit
to Automattic/vip-enterprise-search
that referenced
this pull request
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In some high-concurrency cases rate-limiting window never expires and results in prolonged rate-limit.
Changelog Description
Fixed
Pre-review checklist
Please make sure the items below have been covered before requesting a review:
Pre-deploy checklist
Steps to Test