Partner Aware Onboarding - Customizations for Square #1426

moon0326 · 2024-01-12T00:42:50Z

Changes proposed in this Pull Request:

This PR removes Woo Payments from the following REST API endpoints when woocommerce_onboarding_profile.partner is square

/wp-json/wc-admin/payment-gateway-suggestions
/wp-json/wc-admin/onboarding/free-extensions

It also adds Get paid with Square task.

How to test the changes in this Pull Request:

Feed Removal

Checkout this branch.
Make sure you're in trial plan.
Use wp cli to update woocommerce_onboarding_profile option value with a:10:{s:15:"business_choice";s:28:"im_just_starting_my_business";s:21:"selling_online_answer";N;s:17:"selling_platforms";N;s:20:"is_store_country_set";b:1;s:8:"industry";a:1:{i:0;N;}s:18:"is_agree_marketing";b:0;s:11:"store_email";s:17:"test@gmail.com";s:9:"completed";b:1;s:23:"is_plugins_page_skipped";b:1;s:7:"partner";s:6:"square";} It includes partner=square
Open your browser's inspector and click Network tab.
Start the core profiler.
On the Tell us a bit about your store page, click Continue button.
Inspect a request to /wp-json/wc-admin/onboarding/free-extensions
Confirm obw/core-profiler.plugins does not have woocommerce-payments
Go to WooCommerce -> Settings -> Payments
Inspect a request to /wp-json/wc-admin/payment-gateway-suggestions
Confirm the response doesn't have woocommerce_payment and woocommerce_payments:with-in-person-payments

Get paid with Square task

Install WooCommerce Square plugin (this will be installed automatically once we deploy WPCOM changes).
Go to WooCommerce -> Home
Confirm Get paid with Square task is the first task.
Click on it.
You should be redirected to Square connect wizard.

Other information:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes, as applicable?

FOR PR REVIEWER ONLY:

I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

github-actions · 2024-01-12T00:46:36Z

Size Change: +197 B (0%)

Total Size: 197 kB

Filename	Size	Change
`./build/index.js`	122 kB	+197 B (0%)

ℹ️ View Unchanged

Filename	Size
`./build/53.js`	1.05 kB
`./build/index.css`	883 B
`./build/marketing.js`	58 kB
`./build/payment-gateway-suggestions.css`	1.25 kB
`./build/payment-gateway-suggestions.js`	6.46 kB
`./build/plugins.js`	3.92 kB
`./build/style-index.css`	2.15 kB
`./build/style-marketing.css`	805 B

_{compressed-size-action}

ilyasfoo

Tested well! I have some comments:

Inspect a request to /wp-json/wc-admin/payment-gateway-suggestions
Confirm the response doesn't have woocommerce_payment and woocommerce_payments:with-in-person-payments

I get an empty array with this request. Is this expected? For context, the request URL was /wp-json/wc-admin/payment-gateway-suggestions?_locale=user, missing force_default_suggestion=true when comparing to the query in payments task.

It seems the task does not have a header.

cc @verofasulo would you be able to suggest a task header design to use for Get paid with Square? Perhaps reusing the payments header? I think we'll also need the copy specific for Square.

includes/free-trial/partners/class-wc-calypso-bridge-partner-square.php

class-wc-calypso-bridge-shared.php

includes/free-trial/partners/class-wc-calypso-bridge-partner-square.php

includes/tasks/class-wc-calypso-task-setup-woocommerce-square.php

includes/free-trial/partners/class-wc-calypso-bridge-partner-square.php

ilyasfoo · 2024-01-31T03:57:03Z

includes/free-trial/partners/class-wc-calypso-bridge-partner-square.php

+	 *
+	 * @return void
+	 */
+	private function remove_woo_payments_from_core_profiler_plugin_suggestions() {


I wonder if this is really needed since Core profiler is technically not in the flow for hosted Woo in WPCOM, but doesn't hurt to have it.

Good point 👍 Let's remove it.

ilyasfoo · 2024-01-31T04:03:44Z

src/index.js

+	// Setup Square task fill (Partner Aware Onboarding).
+	registerPlugin( 'wc-calypso-bridge-task-setup-woocommerce-square', {
+		scope: 'woocommerce-tasks',
+		render: SetupWooCommerceSquareFill,


Since Square is optional (and probably is a very small subset of hosted Woo), I think it'll be beneficial to make this a lazy loaded fill. What if we check for square_connect_url to render it?

Good idea! I'll make the change.

Updated in 5f86d28

includes/free-trial/partners/class-wc-calypso-bridge-partner-square.php

includes/tasks/class-wc-calypso-task-setup-woocommerce-square.php

verofasulo · 2024-01-31T15:43:00Z

Hey @ilyasfoo, thanks for tagging me!

would you be able to suggest a task header design to use for Get paid with Square? Perhaps reusing the payments header? I think we'll also need the copy specific for Square.

Please reuse the header we use for generic payment methods (the one in place when we don't have WooPayments by default):

Keep it as the third task (not first).
Replace "Get paid" with "Get paid with Square" as @lauroraa suggested.
Regarding the header description, we can wait for Square to provide a copy.

…quare.php Co-authored-by: Ilyas Foo <foo.ilyas@gmail.com>

…ilable

moon0326 · 2024-01-31T21:58:14Z

Hey @ilyasfoo, thanks for tagging me!

would you be able to suggest a task header design to use for Get paid with Square? Perhaps reusing the payments header? I think we'll also need the copy specific for Square.

Please reuse the header we use for generic payment methods (the one in place when we don't have WooPayments by default):

Keep it as the third task (not first).

Replace "Get paid" with "Get paid with Square" as @lauroraa suggested.

Regarding the header description, we can wait for Square to provide a copy.

Thank you @verofasulo @ilyasfoo

The task is now placed at the 3rd position with cf2a894 commit.

I've also added the task header with 9f95778

moon0326 · 2024-01-31T22:17:02Z

I get an empty array with this request. Is this expected? For context, the request URL was /wp-json/wc-admin/payment-gateway-suggestions?_locale=user, missing force_default_suggestion=true when comparing to the query in payments task.

@ilyasfoo I've tested it with a fresh site and wasn't able to reproduce it. Could you please provide a screenshot of the request and response?

ilyasfoo · 2024-02-01T04:11:06Z

I've tested it with a fresh site and wasn't able to reproduce it. Could you please provide a screenshot of the request and response?

@moon0326 Here's the request and response

ilyasfoo

Tested well, but I have a few nitpicky comments:

includes/free-trial/partners/class-wc-calypso-bridge-partner-square.php

class-wc-calypso-bridge-shared.php

includes/free-trial/partners/class-wc-calypso-bridge-partner-square.php

src/index.js

…quare.php Co-authored-by: Ilyas Foo <foo.ilyas@gmail.com>

Co-authored-by: Ilyas Foo <foo.ilyas@gmail.com>

moon0326 · 2024-02-01T04:47:18Z

Tested well, but I have a few nitpicky comments:

Thank you for the commits 🙇

ilyasfoo

Thanks, @moon0326 ! Would you like to see if the response (#1426 (comment)) is expected? Otherwise, I think this is good to merge. Pre-approving

Also, just noting that we have a follow-up before launching this:

Regarding the header description, we can wait for Square to provide a copy.

moon0326 · 2024-02-01T05:51:32Z

Thanks, @moon0326 ! Would you like to see if the response (#1426 (comment)) is expected? Otherwise, I think this is good to merge. Pre-approving

Also, just noting that we have a follow-up before launching this:

Regarding the header description, we can wait for Square to provide a copy.

Thank you! I'll try to reproduce it again.

Regarding the header description, we can wait for Square to provide a copy.

I think we can request it and update it in a follow-up PR. I want everyone to start testing it easily on production soon.

moon0326 · 2024-02-01T05:57:51Z

Thanks, @moon0326 ! Would you like to see if the response (#1426 (comment)) is expected? Otherwise, I think this is good to merge. Pre-approving

Also, just noting that we have a follow-up before launching this:

Regarding the header description, we can wait for Square to provide a copy.

I've tested it with a fresh site and wasn't able to reproduce it. Could you please provide a screenshot of the request and response?

@moon0326 Here's the request and response

Thank you!

Could you check the following options?

The endpoint returns an empty array when woocommerce_show_marketplace_suggestions is set to no
OR
woocommerce_setting_payments_recommendations_hidden is set to yes

ilyasfoo · 2024-02-01T07:41:56Z

The endpoint returns an empty array when woocommerce_show_marketplace_suggestions is set to no

@moon0326 That's it, I had this set to no. Now it's testing well, thanks!

moon0326 added 2 commits January 10, 2024 16:41

A new class to customize partner sites

ae6d1de

Remvoe inbox note removal code

63e5ba7

moon0326 marked this pull request as draft January 12, 2024 00:42

moon0326 mentioned this pull request Jan 17, 2024

[Partner Aware Onboarding] Disable Woo Payments promotions #1422

Closed

moon0326 added 7 commits January 23, 2024 16:21

Move partner square class to free-trial directory

b4b820e

Add changelog

f4eb7ab

Update class comment

4fe69f1

Make sure to reindex plugins

493b7ad

Merge branch 'master' into update/1422-disable-woo-payments-promotions

2a2148c

Make sure we are only applying the changes for free-trial plans

b4ae4d4

Remove test code

7b220b9

moon0326 marked this pull request as ready for review January 30, 2024 21:29

moon0326 marked this pull request as draft January 30, 2024 23:11

moon0326 added 2 commits January 30, 2024 15:50

Add a new filter for shared JS params

be06b89

Add Setup WooCommerce Square task

9457fed

moon0326 changed the title ~~Disable Woo Payments promotions for partner sites~~ Partner Aware Onboarding - Customization for Square Jan 30, 2024

moon0326 changed the title ~~Partner Aware Onboarding - Customization for Square~~ Partner Aware Onboarding - Customizations for Square Jan 30, 2024

moon0326 requested review from a team, adrianduffell and rjchow January 30, 2024 23:56

moon0326 marked this pull request as ready for review January 30, 2024 23:56

moon0326 requested a review from ilyasfoo January 31, 2024 00:45

moon0326 added 3 commits January 30, 2024 19:45

Update text

7265a6f

Update text rev2

24c1b45

Make sure Square plugin is installed before adding the task

21da0e7

ilyasfoo requested changes Jan 31, 2024

View reviewed changes

moon0326 and others added 2 commits January 31, 2024 08:50

Update includes/free-trial/partners/class-wc-calypso-bridge-partner-s…

afe89b2

…quare.php Co-authored-by: Ilyas Foo <foo.ilyas@gmail.com>

Update includes/free-trial/partners/class-wc-calypso-bridge-partner-s…

7bb8fc2

…quare.php Co-authored-by: Ilyas Foo <foo.ilyas@gmail.com>

moon0326 added 8 commits January 31, 2024 13:34

Add file version tag

335e415

Do not remove woo payments from core profiler plugin feed -- not needed

5f86d28

Add filter doc

c0710d9

Use wc-calypso-bridge for translation group

fb07e2b

Render SetupWooCommerceSquareFill only when square_connect_url is ava…

4610c3c

…ilable

Place Square task at the 3rd position

cf2a894

Rename setup-woocommerce-square to get-paid-with-square

c5a5b15

Add get paid with square task header

9f95778

moon0326 added 2 commits January 31, 2024 13:59

Use correct id for the square task header

0cde0a2

Remove woocommerce_payments:without-in-person-payments as well

573d39d

ilyasfoo reviewed Feb 1, 2024

View reviewed changes

moon0326 and others added 4 commits January 31, 2024 20:45

Update includes/free-trial/partners/class-wc-calypso-bridge-partner-s…

0ee7cf2

…quare.php Co-authored-by: Ilyas Foo <foo.ilyas@gmail.com>

Update includes/free-trial/partners/class-wc-calypso-bridge-partner-s…

277cc85

…quare.php Co-authored-by: Ilyas Foo <foo.ilyas@gmail.com>

Update includes/free-trial/partners/class-wc-calypso-bridge-partner-s…

95194a6

…quare.php Co-authored-by: Ilyas Foo <foo.ilyas@gmail.com>

Update class-wc-calypso-bridge-shared.php

77449e3

Co-authored-by: Ilyas Foo <foo.ilyas@gmail.com>

ilyasfoo self-requested a review February 1, 2024 05:34

ilyasfoo approved these changes Feb 1, 2024

View reviewed changes

moon0326 merged commit dc6a6c1 into master Feb 1, 2024
5 checks passed

moon0326 mentioned this pull request Feb 1, 2024

Prepare for release 2.3.5 #1437

Closed

moon0326 added a commit that referenced this pull request Feb 1, 2024

Update version for #1426

e055888

moon0326 mentioned this pull request Feb 2, 2024

Prepare for release 2.3.5 #1438

Merged

moon0326 added a commit that referenced this pull request Feb 2, 2024

Update version for #1426

45e22ac

epeicher mentioned this pull request Jul 18, 2024

Update Onbarding steps for PayPal #1491

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Partner Aware Onboarding - Customizations for Square #1426

Partner Aware Onboarding - Customizations for Square #1426

moon0326 commented Jan 12, 2024 •

edited

Loading

github-actions bot commented Jan 12, 2024 •

edited

Loading

ilyasfoo left a comment

ilyasfoo Jan 31, 2024

moon0326 Jan 31, 2024

ilyasfoo Jan 31, 2024

moon0326 Jan 31, 2024

moon0326 Jan 31, 2024

verofasulo commented Jan 31, 2024

moon0326 commented Jan 31, 2024

moon0326 commented Jan 31, 2024 •

edited

Loading

ilyasfoo commented Feb 1, 2024

ilyasfoo left a comment

moon0326 commented Feb 1, 2024

ilyasfoo left a comment

moon0326 commented Feb 1, 2024 •

edited

Loading

moon0326 commented Feb 1, 2024

ilyasfoo commented Feb 1, 2024

Partner Aware Onboarding - Customizations for Square #1426

Partner Aware Onboarding - Customizations for Square #1426

Conversation

moon0326 commented Jan 12, 2024 • edited Loading

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Other information:

FOR PR REVIEWER ONLY:

github-actions bot commented Jan 12, 2024 • edited Loading

ilyasfoo left a comment

Choose a reason for hiding this comment

ilyasfoo Jan 31, 2024

Choose a reason for hiding this comment

moon0326 Jan 31, 2024

Choose a reason for hiding this comment

ilyasfoo Jan 31, 2024

Choose a reason for hiding this comment

moon0326 Jan 31, 2024

Choose a reason for hiding this comment

moon0326 Jan 31, 2024

Choose a reason for hiding this comment

verofasulo commented Jan 31, 2024

moon0326 commented Jan 31, 2024

moon0326 commented Jan 31, 2024 • edited Loading

ilyasfoo commented Feb 1, 2024

ilyasfoo left a comment

Choose a reason for hiding this comment

moon0326 commented Feb 1, 2024

ilyasfoo left a comment

Choose a reason for hiding this comment

moon0326 commented Feb 1, 2024 • edited Loading

moon0326 commented Feb 1, 2024

ilyasfoo commented Feb 1, 2024

moon0326 commented Jan 12, 2024 •

edited

Loading

github-actions bot commented Jan 12, 2024 •

edited

Loading

moon0326 commented Jan 31, 2024 •

edited

Loading

moon0326 commented Feb 1, 2024 •

edited

Loading