Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for product count instead of click in checklist #475

Merged
merged 1 commit into from
Jul 23, 2019
Merged

Check for product count instead of click in checklist #475

merged 1 commit into from
Jul 23, 2019

Conversation

joshuatf
Copy link
Contributor

Checks for any products and marks complete if they exist instead of checking for a click.

Screenshot

Screen Shot 2019-07-22 at 10 45 53 PM

Testing

  1. Visit wp-admin/admin.php?page=wc-setup-checklist
  2. Make sure the item is not marked completed for stores with no products.
  3. Make sure the item is marked completed as soon as any products are added.

@joshuatf joshuatf self-assigned this Jul 22, 2019
timmyc
timmyc approved these changes Jul 22, 2019
View reviewed changes
Copy link
Contributor

@timmyc timmyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the expected behavior when no products exist, and the item being ticked off my check list once a product has been published.

@joshuatf joshuatf merged commit 0500bd8 into master Jul 23, 2019
@joshuatf joshuatf deleted the fix/464 branch July 23, 2019 03:36
vindl pushed a commit that referenced this pull request Mar 31, 2023
@joshuatf
Check for product count instead of click in checklist (#475)
331d676
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmyc timmyc timmyc approved these changes

@justinshreve justinshreve Awaiting requested review from justinshreve

Assignees

@joshuatf joshuatf

Labels
eCommerce Plan [Status] Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshuatf @timmyc