Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JPC: Add a notice to the invalid credentials error notice #24279

Closed
joanrho opened this issue Apr 17, 2018 · 2 comments
Closed

JPC: Add a notice to the invalid credentials error notice #24279

joanrho opened this issue Apr 17, 2018 · 2 comments
Assignees
@joanrho @seear @AnnaMag
Labels
Jetpack [Type] Enhancement
Projects
Jetpack: Remote Installs

Comments

@joanrho
Copy link
Contributor

joanrho commented Apr 17, 2018

Relates to #23997 (already merged).

Let's add a red notice alerting users that their credentials were invalid right above the username/pw text fields in the white box:

screen shot 2018-04-17 at 2 44 55 pm
@joanrho joanrho added this to To do in Jetpack: Remote Installs via automation Apr 17, 2018
@seear
Copy link
Contributor

seear commented Apr 18, 2018

The change to highlight just one of username or password is in this PR #24298.

That one is quite large, so I'll add the notice in a separate PR.

@seear
Copy link
Contributor

seear commented Apr 19, 2018

Also:

add a red error text below the highlighted field saying "Username does not exist. Please try again." (for username error) and "Incorrect password. Please try again." (for password error)?

This was referenced Apr 19, 2018
Merged
Merged
Jetpack: Remote Installs automation moved this from To do to Done Apr 23, 2018
seear added a commit that referenced this issue Apr 23, 2018
@seear
JP Remote Connect: Make invalid credentials notice clearer (#24338)
33acc06 
Add a bolder notice and standard messages under the highlighted user or password field.

Fixes #24279.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joanrho joanrho

@seear seear

@AnnaMag AnnaMag

Labels
Jetpack [Type] Enhancement
Projects
No open projects
Jetpack: Remote Installs
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joanrho @seear @AnnaMag