Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP Remote Connect: Make invalid credentials notice clearer #24338

Merged
merged 5 commits into from
Apr 23, 2018

Conversation

seear
Copy link
Contributor

@seear seear commented Apr 19, 2018

Fixes #24279.

Before

screen shot 2018-04-23 at 16 20 56screen shot 2018-04-23 at 16 20 37

After

screen shot 2018-04-23 at 16 19 39screen shot 2018-04-23 at 16 20 02

Testing

@seear seear self-assigned this Apr 19, 2018
@seear seear added this to To do in Jetpack: Remote Installs via automation Apr 19, 2018
@matticbot
Copy link
Contributor

{ this.isInvalidPassword() && (
<FormInputValidation
isError
text={ translate( 'Incorrect password. Please try again.' ) }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! I've found a possible matching string that has already been translated 16 times:
translate( 'Your password is incorrect, please try again' ) ES Score: 12

Help me improve these suggestions: react with 👎 if the suggestion doesn't make any sense, or with 👍 if it's a particularly good one (even if not implemented).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@seear seear requested review from joanrho, AnnaMag and a team April 23, 2018 15:28
@seear seear added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Apr 23, 2018
Copy link
Member

@sirreal sirreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well 👍

Copy link
Contributor

@joanrho joanrho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly. Thanks, @seear! 🚢

@seear seear merged commit 33acc06 into master Apr 23, 2018
Jetpack: Remote Installs automation moved this from To do to Done Apr 23, 2018
@seear seear deleted the update/jp-remote-install/creds-notice branch April 23, 2018 16:27
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants