Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ad Control to AdControl in static admin menu data #45995

Closed
getdave opened this issue Sep 29, 2020 · 0 comments · Fixed by #46001
Closed

Update Ad Control to AdControl in static admin menu data #45995

getdave opened this issue Sep 29, 2020 · 0 comments · Fixed by #46001
Assignees
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. [Type] Task

Comments

@getdave
Copy link
Contributor

getdave commented Sep 29, 2020

@getdave
Sorry for bringing that up, but I've noticed that the actual menu entry for 'AdControl' doesn't have a space in it and is also not translated (in wordads-userdash), while the placeholder data has 'Ad Control' in it, which our translators are now translating. The effect of this would be that the users who see the fallback data would see something like 'Gestión de anuncios' for Spanish and then 'AdControl' when the actual menu would be loaded.
It's possible to switch to using 'AdControl' in the fallback data and not translate it, in case that it's a product name and it'd appear the same in all the languages. Or translate 'AdControl' both in the placeholder data and the actual menu entry and have some guidelines on how it should be translated so that it'd be consistent across all languages.

I discussed this with @dlind1 and we agreed to:

  • Match static data to canonical reference (see wordads-userdash/wordads-info.php#39) for the AdControl menu item - change Ad Control to be AdControl within the static data.
  • We agreed to retain the existing translate() wrapper around AdControl in the static data even though the canonical version in PHP is not yet translated.

Originally posted by @getdave in #45836 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. [Type] Task
Projects
None yet
1 participant