Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav Unification - updates Ad Control in static data to match canonical WPCom menu item name #46001

Merged
merged 1 commit into from
Sep 29, 2020

Conversation

getdave
Copy link
Contributor

@getdave getdave commented Sep 29, 2020

Updates menu item Ad Control to be AdControl in the static data in order to better match the menu text in the WPCom code which will create the real menu.

See #45995

cc @davemart-in - just an FYI this is happening and why.

Changes proposed in this Pull Request

  • Updates Ad Control in the static menu data to match the canonical AdControl title from WPCom.

Testing instructions

#45995

@getdave getdave requested review from davemart-in and a team September 29, 2020 13:26
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 29, 2020
@matticbot
Copy link
Contributor

@getdave getdave added the [Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. label Sep 29, 2020
@getdave getdave linked an issue Sep 29, 2020 that may be closed by this pull request
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@davemart-in davemart-in left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@getdave
Copy link
Contributor Author

getdave commented Sep 29, 2020

I'm 100% this change hasn't caused the failing e2e tests. Shipping.

@getdave getdave added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Sep 29, 2020
@getdave getdave merged commit 6773d27 into master Sep 29, 2020
@getdave getdave deleted the fix/nav-item-ad-control-format branch September 29, 2020 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Ad Control to AdControl in static admin menu data
5 participants