Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sites: Gap/space missing between sites for every 3rd site #5

Closed
alisterscott opened this issue Nov 17, 2015 · 0 comments · Fixed by #1082
Closed

Sites: Gap/space missing between sites for every 3rd site #5

alisterscott opened this issue Nov 17, 2015 · 0 comments · Fixed by #1082
Assignees
@gwwar
Labels
Sites [Type] Bug
Milestone
Core: Iteration 17

Comments

@alisterscott
Copy link
Contributor

When viewing wordpress.com/sites on a mobile device (or a narrow screen size), the gap/space between every third site is missing.

sites_no_gap_mobile

Expect to see the same space/gap between every site.
@rralian rralian added this to the Core: Iteration 17 milestone Nov 30, 2015
@gwwar gwwar self-assigned this Dec 1, 2015
@gwwar gwwar mentioned this issue Dec 1, 2015
Merged
This was referenced Jul 10, 2016
Closed
Merged
Merged
@MichaelArestad MichaelArestad mentioned this issue Oct 25, 2017
Closed
sirreal pushed a commit that referenced this issue Dec 5, 2018
@aduth @sirreal
Merge pull request #5 from bluefuton/add/comma-dangle-always-multiline
05b1621 
Set comma-dangle to 'always-multiline'
sirreal pushed a commit that referenced this issue Dec 5, 2018
@blowery @sirreal
Add support for the ssl parameter to fetch images from https URLs
ee76c53 
Closes #5.
sirreal pushed a commit that referenced this issue Dec 5, 2018
@aduth @sirreal
Merge pull request #5 from bluefuton/add/comma-dangle-always-multiline
8044ab7 
Set comma-dangle to 'always-multiline'
sirreal pushed a commit that referenced this issue Dec 5, 2018
@blowery @sirreal
Add support for the ssl parameter to fetch images from https URLs
cd07491 
Closes #5.
sirreal pushed a commit that referenced this issue Dec 6, 2018
@ockham @sirreal
Merge pull request #5 from Automattic/upgrade/interpolate-components-…
3f6585e 
…1-1-0

Bump interpolate-components to 1.1.0
sirreal pushed a commit that referenced this issue Dec 6, 2018
@aduth @sirreal
Merge pull request #5 from bluefuton/add/comma-dangle-always-multiline
3fb3795 
Set comma-dangle to 'always-multiline'
sirreal pushed a commit that referenced this issue Dec 6, 2018
@blowery @sirreal
Add support for the ssl parameter to fetch images from https URLs
bc5ea7c 
Closes #5.
sirreal pushed a commit that referenced this issue Dec 7, 2018
@ockham @sirreal
Merge pull request #5 from Automattic/upgrade/interpolate-components-…
697c8db 
…1-1-0

Bump interpolate-components to 1.1.0
blowery added a commit that referenced this issue Dec 7, 2018
@blowery
Add support for the ssl parameter to fetch images from https URLs
7cd8d45 
Closes #5.
sirreal pushed a commit that referenced this issue Dec 7, 2018
@ockham @sirreal
Merge pull request #5 from Automattic/upgrade/interpolate-components-…
0b94463 
…1-1-0

Bump interpolate-components to 1.1.0
sirreal pushed a commit that referenced this issue Dec 11, 2018
@ockham @sirreal
Merge pull request #5 from Automattic/upgrade/interpolate-components-…
bcc4e9c 
…1-1-0

Bump interpolate-components to 1.1.0
sirreal pushed a commit that referenced this issue Dec 11, 2018
@blowery @sirreal
Add support for the ssl parameter to fetch images from https URLs
66b0e9f 
Closes #5.
sirreal pushed a commit that referenced this issue Dec 11, 2018
@aduth @sirreal
Merge pull request #5 from bluefuton/add/comma-dangle-always-multiline
1454f39 
Set comma-dangle to 'always-multiline'
sirreal pushed a commit that referenced this issue Dec 11, 2018
@ockham @sirreal
Merge pull request #5 from Automattic/upgrade/interpolate-components-…
7b495ec 
…1-1-0

Bump interpolate-components to 1.1.0
sirreal pushed a commit that referenced this issue Dec 20, 2018
@blowery @sirreal
Add support for the ssl parameter to fetch images from https URLs
8aaeca4 
Closes #5.
sirreal pushed a commit that referenced this issue Jan 7, 2019
@blowery @sirreal
Add support for the ssl parameter to fetch images from https URLs
08151c5 
Closes #5.
sirreal pushed a commit that referenced this issue Jan 11, 2019
@blowery @sirreal
Add support for the ssl parameter to fetch images from https URLs
29cee34 
Closes #5.
blowery added a commit that referenced this issue Feb 19, 2019
@blowery
Add support for the ssl parameter to fetch images from https URLs
de9661c 
Closes #5.
sirreal pushed a commit that referenced this issue Feb 20, 2019
@blowery @sirreal
Add support for the ssl parameter to fetch images from https URLs
cfd33ab 
Closes #5.
sirreal pushed a commit that referenced this issue Oct 10, 2019
@coreylight @sirreal
Fix codemod name in documentation (#5)
67b7a2a
sirreal pushed a commit that referenced this issue Oct 11, 2019
@coreylight @sirreal
Fix codemod name in documentation (#5)
7dc1480
sirreal pushed a commit that referenced this issue Oct 16, 2019
@coreylight @sirreal
Fix codemod name in documentation (#5)
ee70aff
sirreal pushed a commit that referenced this issue Nov 14, 2019
@coreylight @sirreal
Fix codemod name in documentation (#5)
8ff755c
sirreal added a commit that referenced this issue Nov 14, 2019
@sirreal
Calypso Codemods: Pull in to monorepo (#36645)
8037766 
* first commit

* copy files from wp-calypso

* Run script + setup test harness

* Make index.js a binary

* add travis config and tweak README

* add section to readme explaining how to add new tests

* prettify + remove all references to config

* add tests: merge-lodash-imports

* tests: add modular-lodash-no-more

* tests: add combine-reducer-with-persistence

* tests: add combine-state-utils-imports

* tests: add i18n-mixin-to-localize

* tests: add modular-lodash-requires-no-more

* i18n-mixin-to-localize: must use dbl quotes

* bump package for release

* Fix build for npm

* should be able to run from anywhere

* fix broken deps so tests can pass. do not use yarn

* no yarn

* add single tree rendering

* Update dependencies to latests versions (#4)

* Update dependencies to latests versions

Updated deps, hopefully to get rid of GitHub's security warnings about `hoek`.
The update also updated `package.json` to NPM 6 format.

* Tell Travis CI to use Node 10

* Fix codemod name in documentation (#5)

* Merge pull request #8 from Automattic/add/remove-create-reducer

Add codemod to remove create-reducer

* Prep for calypso

* npm install
@stephanethomas stephanethomas mentioned this issue Nov 19, 2019
Merged
sgomes pushed a commit that referenced this issue Jan 29, 2020
@skeltoac @sgomes
Merge pull request #15 from Automattic/fix/#5
e06230a 
Fix TypeError on string body 'error' from rest-proxy
sgomes pushed a commit that referenced this issue Jan 29, 2020
@dmsnell @sgomes
Fix: Stop treating completely failed network requests as successes (#20)
8fd1e4c 
* Fix: Stop treating completely failed network requests as successes

Resolves #5

When certain network requests fail because the internet connection is completely broken they are coming through as if they were successes and the passed callback is called with `(err = null, data = {})`. This breaks the application logic which depends on failing requests actually failing.

I added the strict-equality check on the returned `statusCode` because I noticed that when the network connection was severed it was coming back with a value of `0` and not `null`. This appears to fix the problem I'm observing.

On the other hand, it's not clear to me when the status would be `null` or why this check is in there to begin with. I'm not sure what other things could be breaking as a result of this change. Would really appreciate some review and some insight into this odd behavior.

Thanks!

* Only accept 2XX status codes as successful requests

* pkg: bump to 4.0.0-alpha.1 version

* Bump package version to v4.0.1
sgomes pushed a commit that referenced this issue Feb 18, 2020
@skeltoac @sgomes
Merge pull request #15 from Automattic/fix/#5
c9f5461 
Fix TypeError on string body 'error' from rest-proxy
sgomes pushed a commit that referenced this issue Feb 18, 2020
@dmsnell @sgomes
Fix: Stop treating completely failed network requests as successes (#20)
e52510d 
* Fix: Stop treating completely failed network requests as successes

Resolves #5

When certain network requests fail because the internet connection is completely broken they are coming through as if they were successes and the passed callback is called with `(err = null, data = {})`. This breaks the application logic which depends on failing requests actually failing.

I added the strict-equality check on the returned `statusCode` because I noticed that when the network connection was severed it was coming back with a value of `0` and not `null`. This appears to fix the problem I'm observing.

On the other hand, it's not clear to me when the status would be `null` or why this check is in there to begin with. I'm not sure what other things could be breaking as a result of this change. Would really appreciate some review and some insight into this odd behavior.

Thanks!

* Only accept 2XX status codes as successful requests

* pkg: bump to 4.0.0-alpha.1 version

* Bump package version to v4.0.1
becdetat added a commit that referenced this issue Jan 20, 2021
@becdetat
Bump CI #5
ce038fa
becdetat added a commit that referenced this issue Jan 20, 2021
@becdetat
Add show on hover to info popover (#48990)
7ecca39 
* Add show on hover cap. to info popover

* Bump CI

* Bump CI #2

* Change popover timeout to 250ms

* Bump CI #3

* Bump CI #4

* Bump CI #5
@kwight kwight mentioned this issue Oct 7, 2021
Closed
14 tasks
@yashwin yashwin mentioned this issue Jan 6, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gwwar gwwar

Labels
Sites [Type] Bug
Projects
None yet
Milestone
Core: Iteration 17
Development

Successfully merging a pull request may close this issue.

Sites: fix missing margin on every 3rd card in mobile Automattic/wp-calypso
3 participants
@alisterscott @rralian @gwwar