Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Picker: Always show search if user has hidden site #4

Closed
alisterscott opened this issue Nov 17, 2015 · 0 comments
Closed

Site Picker: Always show search if user has hidden site #4

alisterscott opened this issue Nov 17, 2015 · 0 comments

Comments

@alisterscott
Copy link
Contributor

The site picker shows a search if a user has more than 6 sites:

mysites_shows_search

And doesn't show if a user has 6 or less sites

mysites_doesnt_show_search

A user can set a site to be hidden on the dashboard, although it will still appear via my sites search:

search_shows_hidden_sites

If a user has 6 or less 'visible' sites but some 'hidden' sites they will not see the search box and can't select a visible site.

Enhancement: If a user has any hidden sites, always show the search box even if they have 6 or less 'visible' sites

@mtias mtias self-assigned this Nov 17, 2015
richardmuscat added a commit that referenced this issue May 19, 2017
- Kill variations #2 and #4
- Switch to 50/50 split
sirreal pushed a commit that referenced this issue May 19, 2017
* Jetpack: A/B test regarding headlines #3

- Kill variations #2 and #4
- Switch to 50/50 split
mcsf pushed a commit that referenced this issue Aug 21, 2017
* Post Editor: Add revisions list and diff viewer

* Editor Revisions List > Item: Fix leftover from when it wasn't a component on its own

* Editor Sidebar: Fix usage from a ternary to a simple `&&`

* Editor Revisions: `isRequired`-ify components propTypes

* Post Revisions: Internalize normalizers in the revisions selectors

* Post Revisions: default order by dates (more recent first) in `getPostRevisions`

* Update to external 'prop-types' module

* Refactor imports and destructuring assignments

* Post-rebase fixes

* Revisions: Reset state in own lifecycle, not Editor methods

* Picking nits.

* Address feedback (minor)

Props @bperson
sirreal pushed a commit that referenced this issue Dec 5, 2018
Add accessibility linters as a possible configuration file
sirreal pushed a commit that referenced this issue Dec 5, 2018
Photon doesn't support them.

Closes #4.

Squashed commit of the following:

commit 7a5e4049d05e865b9daa280df80369b8219a0c77
Author: Ben Lowery <ben.lowery@automattic.com>
Date:   Mon Feb 1 10:42:36 2016 -0500

    Return null for external URLs that contain querystrings

commit b7fd525f82d19a8208d2ff7e293c7fccebcd7b12
Author: Ben Lowery <ben.lowery@automattic.com>
Date:   Wed Apr 15 14:28:59 2015 -0400

    Don't attempt to photon URLs that use a querystring.

    Photon doesn't support them.
sirreal pushed a commit that referenced this issue Dec 5, 2018
Add accessibility linters as a possible configuration file
sirreal pushed a commit that referenced this issue Dec 5, 2018
Photon doesn't support them.

Closes #4.

Squashed commit of the following:

commit 7a5e4049d05e865b9daa280df80369b8219a0c77
Author: Ben Lowery <ben.lowery@automattic.com>
Date:   Mon Feb 1 10:42:36 2016 -0500

    Return null for external URLs that contain querystrings

commit b7fd525f82d19a8208d2ff7e293c7fccebcd7b12
Author: Ben Lowery <ben.lowery@automattic.com>
Date:   Wed Apr 15 14:28:59 2015 -0400

    Don't attempt to photon URLs that use a querystring.

    Photon doesn't support them.
sirreal pushed a commit that referenced this issue Dec 6, 2018
sirreal pushed a commit that referenced this issue Dec 6, 2018
Add accessibility linters as a possible configuration file
sirreal pushed a commit that referenced this issue Dec 6, 2018
Photon doesn't support them.

Closes #4.

Squashed commit of the following:

commit 7a5e4049d05e865b9daa280df80369b8219a0c77
Author: Ben Lowery <ben.lowery@automattic.com>
Date:   Mon Feb 1 10:42:36 2016 -0500

    Return null for external URLs that contain querystrings

commit b7fd525f82d19a8208d2ff7e293c7fccebcd7b12
Author: Ben Lowery <ben.lowery@automattic.com>
Date:   Wed Apr 15 14:28:59 2015 -0400

    Don't attempt to photon URLs that use a querystring.

    Photon doesn't support them.
sirreal pushed a commit that referenced this issue Dec 7, 2018
blowery added a commit that referenced this issue Dec 7, 2018
Photon doesn't support them.

Closes #4.

Squashed commit of the following:

commit 7a5e4049d05e865b9daa280df80369b8219a0c77
Author: Ben Lowery <ben.lowery@automattic.com>
Date:   Mon Feb 1 10:42:36 2016 -0500

    Return null for external URLs that contain querystrings

commit b7fd525f82d19a8208d2ff7e293c7fccebcd7b12
Author: Ben Lowery <ben.lowery@automattic.com>
Date:   Wed Apr 15 14:28:59 2015 -0400

    Don't attempt to photon URLs that use a querystring.

    Photon doesn't support them.
sirreal pushed a commit that referenced this issue Dec 7, 2018
sirreal pushed a commit that referenced this issue Dec 11, 2018
sirreal pushed a commit that referenced this issue Dec 11, 2018
Photon doesn't support them.

Closes #4.

Squashed commit of the following:

commit 7a5e4049d05e865b9daa280df80369b8219a0c77
Author: Ben Lowery <ben.lowery@automattic.com>
Date:   Mon Feb 1 10:42:36 2016 -0500

    Return null for external URLs that contain querystrings

commit b7fd525f82d19a8208d2ff7e293c7fccebcd7b12
Author: Ben Lowery <ben.lowery@automattic.com>
Date:   Wed Apr 15 14:28:59 2015 -0400

    Don't attempt to photon URLs that use a querystring.

    Photon doesn't support them.
sirreal pushed a commit that referenced this issue Dec 11, 2018
Add accessibility linters as a possible configuration file
sirreal pushed a commit that referenced this issue Dec 11, 2018
sirreal pushed a commit that referenced this issue Dec 20, 2018
Photon doesn't support them.

Closes #4.

Squashed commit of the following:

commit 7a5e4049d05e865b9daa280df80369b8219a0c77
Author: Ben Lowery <ben.lowery@automattic.com>
Date:   Mon Feb 1 10:42:36 2016 -0500

    Return null for external URLs that contain querystrings

commit b7fd525f82d19a8208d2ff7e293c7fccebcd7b12
Author: Ben Lowery <ben.lowery@automattic.com>
Date:   Wed Apr 15 14:28:59 2015 -0400

    Don't attempt to photon URLs that use a querystring.

    Photon doesn't support them.
sirreal pushed a commit that referenced this issue Jan 7, 2019
Photon doesn't support them.

Closes #4.

Squashed commit of the following:

commit 7a5e4049d05e865b9daa280df80369b8219a0c77
Author: Ben Lowery <ben.lowery@automattic.com>
Date:   Mon Feb 1 10:42:36 2016 -0500

    Return null for external URLs that contain querystrings

commit b7fd525f82d19a8208d2ff7e293c7fccebcd7b12
Author: Ben Lowery <ben.lowery@automattic.com>
Date:   Wed Apr 15 14:28:59 2015 -0400

    Don't attempt to photon URLs that use a querystring.

    Photon doesn't support them.
sirreal pushed a commit that referenced this issue Jan 11, 2019
Photon doesn't support them.

Closes #4.

Squashed commit of the following:

commit 7a5e4049d05e865b9daa280df80369b8219a0c77
Author: Ben Lowery <ben.lowery@automattic.com>
Date:   Mon Feb 1 10:42:36 2016 -0500

    Return null for external URLs that contain querystrings

commit b7fd525f82d19a8208d2ff7e293c7fccebcd7b12
Author: Ben Lowery <ben.lowery@automattic.com>
Date:   Wed Apr 15 14:28:59 2015 -0400

    Don't attempt to photon URLs that use a querystring.

    Photon doesn't support them.
blowery added a commit that referenced this issue Feb 19, 2019
Photon doesn't support them.

Closes #4.

Squashed commit of the following:

commit 7a5e4049d05e865b9daa280df80369b8219a0c77
Author: Ben Lowery <ben.lowery@automattic.com>
Date:   Mon Feb 1 10:42:36 2016 -0500

    Return null for external URLs that contain querystrings

commit b7fd525f82d19a8208d2ff7e293c7fccebcd7b12
Author: Ben Lowery <ben.lowery@automattic.com>
Date:   Wed Apr 15 14:28:59 2015 -0400

    Don't attempt to photon URLs that use a querystring.

    Photon doesn't support them.
sirreal pushed a commit that referenced this issue Feb 20, 2019
Photon doesn't support them.

Closes #4.

Squashed commit of the following:

commit 7a5e4049d05e865b9daa280df80369b8219a0c77
Author: Ben Lowery <ben.lowery@automattic.com>
Date:   Mon Feb 1 10:42:36 2016 -0500

    Return null for external URLs that contain querystrings

commit b7fd525f82d19a8208d2ff7e293c7fccebcd7b12
Author: Ben Lowery <ben.lowery@automattic.com>
Date:   Wed Apr 15 14:28:59 2015 -0400

    Don't attempt to photon URLs that use a querystring.

    Photon doesn't support them.
sirreal pushed a commit that referenced this issue Oct 10, 2019
* Update dependencies to latests versions

Updated deps, hopefully to get rid of GitHub's security warnings about `hoek`.
The update also updated `package.json` to NPM 6 format.

* Tell Travis CI to use Node 10
sirreal pushed a commit that referenced this issue Oct 11, 2019
* Update dependencies to latests versions

Updated deps, hopefully to get rid of GitHub's security warnings about `hoek`.
The update also updated `package.json` to NPM 6 format.

* Tell Travis CI to use Node 10
sirreal pushed a commit that referenced this issue Oct 16, 2019
* Update dependencies to latests versions

Updated deps, hopefully to get rid of GitHub's security warnings about `hoek`.
The update also updated `package.json` to NPM 6 format.

* Tell Travis CI to use Node 10
sirreal pushed a commit that referenced this issue Nov 14, 2019
* Update dependencies to latests versions

Updated deps, hopefully to get rid of GitHub's security warnings about `hoek`.
The update also updated `package.json` to NPM 6 format.

* Tell Travis CI to use Node 10
sirreal added a commit that referenced this issue Nov 14, 2019
* first commit

* copy files from wp-calypso

* Run script + setup test harness

* Make index.js a binary

* add travis config and tweak README

* add section to readme explaining how to add new tests

* prettify + remove all references to config

* add tests: merge-lodash-imports

* tests: add modular-lodash-no-more

* tests: add combine-reducer-with-persistence

* tests: add combine-state-utils-imports

* tests: add i18n-mixin-to-localize

* tests: add modular-lodash-requires-no-more

* i18n-mixin-to-localize: must use dbl quotes

* bump package for release

* Fix build for npm

* should be able to run from anywhere

* fix broken deps so tests can pass. do not use yarn

* no yarn

* add single tree rendering

* Update dependencies to latests versions (#4)

* Update dependencies to latests versions

Updated deps, hopefully to get rid of GitHub's security warnings about `hoek`.
The update also updated `package.json` to NPM 6 format.

* Tell Travis CI to use Node 10

* Fix codemod name in documentation (#5)

* Merge pull request #8 from Automattic/add/remove-create-reducer

Add codemod to remove create-reducer

* Prep for calypso

* npm install
jsnajdr pushed a commit that referenced this issue Jan 27, 2020
Adding `sites` functionality to retrieve a list of sites for the current...
sgomes pushed a commit that referenced this issue Jan 29, 2020
Return an XMLHttpRequest instance, add support for "progress" events
sgomes pushed a commit that referenced this issue Feb 18, 2020
Return an XMLHttpRequest instance, add support for "progress" events
becdetat added a commit that referenced this issue Jan 20, 2021
becdetat added a commit that referenced this issue Jan 20, 2021
* Add show on hover cap. to info popover

* Bump CI

* Bump CI #2

* Change popover timeout to 250ms

* Bump CI #3

* Bump CI #4

* Bump CI #5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants