-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor away from React UNSAFE_*
lifecycle methods
#58453
Labels
Comments
This was referenced Dec 2, 2021
UNSAFE_*
lifecycle methodsUNSAFE_*
lifecycle methods
This was referenced Dec 2, 2021
This was referenced Dec 9, 2021
This was referenced Dec 13, 2021
This was referenced Dec 13, 2021
This was referenced Dec 14, 2021
This was referenced Jan 11, 2022
This was referenced Apr 6, 2022
This was referenced Apr 13, 2022
This was referenced Apr 18, 2022
This was referenced Apr 21, 2022
This was referenced Apr 27, 2022
1 task
This was referenced May 10, 2022
This was referenced May 24, 2022
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Details
We want to refactor away from React
UNSAFE_*
lifecycle methods. While this project has been going on for a while we want to track any remaining occurrences here to make sure we don't loose oversight. At the time of this writing there are ~180 of those unsafe lifecycle methods left.If you need a review or have any questions, please don't hesitate to ping @Automattic/team-calypso-frameworks. It may also be helpful to look into React component documentation to look up with what you might want to replace an unsafe method and/or look at previous refactoring PRs (e.g. #58232, #58232).
Checklist
client/login/magic-login/handle-emailed-link-form.jsx
HandleEmailedLinkForm
: refactor away fromUNSAFE_*
#61163client/login/magic-login/request-login-email-form.jsx
Remove Lodash from client/login #60285client/login/wp-login/index.jsx
Login
: refactor away fromUNSAFE_*
#61165apps/notifications/src/panel/templates/index.jsx
apps/notifications/src/panel/templates/empty-message.jsx
- @tyxla Notifications: RefactorEmptyMessage
away fromUNSAFE_
methods #63276apps/notifications/src/panel/templates/image-loader.jsx
- @tyxla Notifications: RefactorImageLoader
away fromUNSAFE_
methods #63277apps/notifications/src/panel/templates/status-bar.jsx
apps/notifications/src/panel/templates/note-list.jsx
apps/notifications/src/panel/Notifications.jsx
client/jetpack-connect/search.jsx
- @tyxla Jetpack Search: Refactor away fromUNSAFE_
methods #59440client/jetpack-connect/main.jsx
- @tyxla Jetpack Connect: MigrateJetpackConnectMain
away fromUNSAFE_
methods #59169client/jetpack-connect/signup.js
- @tyxla Jetpack Connect: RefactorJetpackSignup
away fromUNSAFE_
methods #61117client/jetpack-connect/remote-credentials.js
@flootrOrgRemoteCredentials
: refactor away fromUNSAFE_*
#61541client/jetpack-connect/sso.jsx
JetpackSsoForm
: refactor away fromUNSAFE_*
#62758client/jetpack-connect/authorize.js
client/post-editor/editor-revisions/dialog.jsx
- @tyxla Editor: RefactorPostRevisionsDialog
away fromUNSAFE_
methods #60484client/post-editor/editor-diff-viewer/index.jsx
- @tyxla Editor: RefactorEditorDiffViewer
away fromUNSAFE_
methods #63172client/lib/analytics/track-component-view/index.jsx
- @tyxla Analytics: MigrateTrackComponentView
away fromUNSAFE_
methods #58860client/lib/url-search/index.js
client/lib/with-dimensions/index.jsx
- @tyxla Reader: RefactorwithDimensions
away fromUNSAFE_
methods #63441client/post-editor/media-modal/detail/detail-preview-image.jsx
@flootrEditorMediaModalDetailPreviewImage
: refactor away fromUNSAFE_*
#61234client/post-editor/media-modal/index.jsx
client/post-editor/media-modal/gallery/index.jsx
@flootrEditorMediaModalGallery
: refactor away fromUNSAFE_*
#62658client/post-editor/media-modal/detail/detail-preview-videopress.jsx
@flootr MediaModal: refactor video editing related cmps away fromUNSAFE_*
#62586client/post-editor/media-modal/detail/detail-fields.jsx
@flootrEditorMediaModalDetailFields
: refactor away fromUNSAFE_*
#62568client/me/help/help-contact-form/index.jsx
client/me/help/help-courses/index.jsx
@tyxla Help: Cleanup courses of unnecessary state #58857client/me/application-passwords/index.jsx
@flootr Migrate App Passwords from Redux to React Query #61562client/me/concierge/reschedule/calendar-step.js
@flootr Concierge: RefactorCalendarStep
away fromUNSAFE_
methods #61814client/me/concierge/book/calendar-step.js
@flootr Concierge: RefactorCalendarStep
away fromUNSAFE_
methods #61814client/me/purchases/confirm-cancel-domain/index.jsx
@flootrConfirmCancelDomain
: refactor away fromUNSAFE_*
#62732client/me/purchases/cancel-purchase/index.jsx
@brookewp Purchases: RefactorCancelPurchase
away fromUNSAFE_
methods #61828client/me/purchases/manage-purchase/index.jsx
- @tyxla Purchases: RefactorManagePurchase
away fromUNSAFE_
methods #60456client/components/token-field/index.jsx
client/components/language-picker/index.jsx
client/components/checklist/checklist.js
- @tyxla Components: RefactorChecklist
away fromUNSAFE_
methods #60289client/components/async-load/index.jsx
client/components/post-schedule/index.jsx
- @tyxla Components: RefactorPostSchedule
away fromUNSAFE_
methods #62220client/components/post-schedule/docs/example.jsx
- @tyxla Components: RefactorPostSchedule
away fromUNSAFE_
methods #62220client/components/data/query-users-suggestions/index.jsx
@flootrQueryUsersMentions
: refactor away fromUNSAFE_*
#60337client/components/data/query-theme/index.jsx
@flootrQueryTheme
: refactor away fromUNSAFE_*
#59979client/components/data/query-plugin-keys/index.jsx
@flootrQueryPluginKeys
: refactor away fromUNSAFE_*
#59982client/components/data/query-keyring-connections/index.jsx
@flootrQueryKeyringConnections
: refactor away fromUNSAFE_*
#59990client/components/data/query-site-guided-transfer/index.jsx
@tyxla Guided Transfer: Remove from this world #60011client/components/data/query-post-stats/index.jsx
QueryPostStats
: refactor away fromUNSAFE_*
#60026client/components/data/query-jetpack-plugins/index.jsx
QueryJetpackPlugins
: refactor away fromUNSAFE_*
#60025client/components/data/query-contact-details-cache/index.jsx
QueryContactDetailsCache
: refactor away fromUNSAFE_*
#60034client/components/data/document-head/index.jsx
- @tyxla Components: RefactorDocumentHead
away fromUNSAFE_
methods #60949client/components/data/query-keyring-services/index.jsx
- @tyxlaQueryKeyringServices
: Migrate away fromUNSAFE_
methods #58753client/components/data/query-reader-lists/index.jsx
- @tyxla Reader: RefactorQueryReaderLists
away fromUNSAFE_
React lifecycle methods #60434client/components/data/query-reader-feed/index.jsx
@flootrQueryReaderFeed
: refactor away fromUNSAFE_*
#60660client/components/data/query-posts/index.jsx
@flootrQueryPosts
: refactor away fromUNSAFE_*
#60532client/components/data/query-post-likes/index.jsx
@flootrQueryPostLikes
: refactor away fromUNSAFE_*
#61152client/components/data/query-concierge-appointment-details/index.js
@flootrQueryConciergeAppointmentDetails
: refactor away fromUNSAFE_*
#60669client/components/data/query-support-article-alternates/index.jsx
@flootrQuerySupportArticleAlternates
: refactor away fromUNSAFE_*
#60396client/components/data/query-reader-site/index.jsx
@flootrQueryReaderSite
: refactor away fromUNSAFE_*
#60488client/components/data/query-post-types/index.jsx
@flootrQueryPostTypes
: refactor away fromUNSAFE_*
#60492client/components/data/query-plans/index.jsx
- @tyxlaQueryPlans
: Migrate away fromUNSAFE_
methods #58757client/components/data/query-site-monitor-settings/index.jsx
- @tyxla Site Settings: Refactor Monitor settings toreact-query
and remove UNSAFE methods #60439client/components/data/query-jetpack-user-connection/index.jsx
- @tyxla Framework: RefactorQueryJetpackUserConnection
away fromUNSAFE_
methods #60960client/components/data/query-reader-tag-images/index.jsx
@flootrQueryReaderTagImages
: refactor away fromUNSAFE_*
#60670client/components/data/query-user-connection/index.jsx
- @jsnajdr Migrate wpcom.undocumented().jetpackIsUserConnected() to wpcom.req #58943client/components/data/query-reader-thumbnails/index.jsx
- @tyxla Reader: RefactorQueryReaderThumbnails
away fromUNSAFE_
methods #60667client/components/data/query-rewind-backup-status/index.js
- @tyxla Activity Log: RefactorQueryRewindBackupStatus
away fromUNSAFE_
methods #61115client/components/data/moderate-comment/index.jsx
- @tyxla Comments: RefactorModerateComment
away fromUNSAFE_
lifecycle methods #60961client/components/data/media-list-data/index.jsx
- @tyxla Media: RefactorMediaListData
away fromUNSAFE_
methods #60991client/components/keyed-suggestions/index.jsx
@flootrclient/components/jetpack/with-server-credentials-form/index.jsx
client/components/input-chrono/index.jsx
client/components/web-preview/content.jsx
- @tyxla Components: RefactorWebPreview
away fromUNSAFE_
lifecycle methods #60663client/components/web-preview/component.jsx
- @tyxla Components: RefactorWebPreview
away fromUNSAFE_
lifecycle methods #60663client/components/image/index.js
- @tyxla Components: RefactorImage
away fromUNSAFE_
methods #62103client/components/search/index.jsx
client/components/infinite-list/index.jsx
client/components/rewind-credentials-form/index.jsx
client/components/track-input-changes/index.jsx
- @tyxla Components: RefactorTrackInputChanges
away fromUNSAFE_
methods #60995client/components/locale-suggestions/index.jsx
- @tyxla Components: MigrateLocaleSuggestions
away fromUNSAFE_
methods #59004client/components/foldable-card/index.jsx
client/components/title-format-editor/index.jsx
client/components/forms/form-phone-input/index.jsx
- @tyxla Components: Refactor away fromUNSAFE_
inFormPhoneInput
#58997client/components/forms/sortable-list/index.jsx
- @tyxla Components: RefactorSortableList
away fromUNSAFE_
methods #61574client/components/domains/registrant-extra-info/fr-form.jsx
- @tyxla Domains: RefactorRegistrantExtraInfoFrForm
away fromUNSAFE_
methods #62256client/components/domains/registrant-extra-info/with-contact-details-validation.jsx
@tyxla Domains: Remove unused TLD validation schemas #58396client/components/domains/registrant-extra-info/uk-form.jsx
- @tyxla Domains: RefactorRegistrantExtraInfoUkForm
away fromUNSAFE_
methods #62255client/components/domains/contact-details-form-fields/index.jsx
- @tyxla Domains: RefactorContactDetailsFormFields
away fromUNSAFE_
methods #62257client/components/domains/trademark-claims-notice/index.jsx
- @tyxla Domains: RefactorTrademarkClaimsNotice
away fromUNSAFE_
methods #62850client/components/domains/transfer-domain-step/index.jsx
client/components/domains/transfer-domain-step/transfer-domain-precheck.jsx
client/components/domains/register-domain-step/index.jsx
client/components/section-nav/index.jsx
client/components/social-buttons/facebook.js
- @tyxla Components: Remove unused Facebook button and icon #58760client/my-sites/post-type-list/max-pages-notice.jsx
- @flootrPostTypeListMaxPagesNotice
: refactor away fromUNSAFE_*
#59121client/my-sites/post-type-list/index.jsx
client/my-sites/customize/main.jsx
- @tyxla Customize: Refactor away fromUNSAFE_
lifecycle methods #63963client/my-sites/earn/ads/form-settings.jsx
- @edanzer Earn: Refactor ad settings to functional component #81048client/my-sites/themes/themes-selection.jsx
- @tyxla Themes: RefactorThemesSelectionWithPage
away fromUNSAFE_
methods #62135client/my-sites/stats/stats-module/index.jsx
- @tyxla Stats: RefactorStatsModule
away fromUNSAFE_
methods #62155client/my-sites/themes/theme-upload/index.jsx
client/my-sites/themes/theme-preview.jsx
client/my-sites/email/email-forwarding/email-forwarding-add-new.jsx
- @stephanethomas Emails: Remove former Email Forwarding page #61572client/my-sites/store/app/store-stats/referrers/index.js
- @tyxla WooCommerce: Remove disabled store referrers stats #60083client/my-sites/store/app/store-stats/store-stats-module/index.js
- @tyxla Stats: RefactorStoreStatsModule
away fromUNSAFE_
lifecycle methods #60946client/my-sites/store/app/store-stats/store-stats-referrer-widget-base/index.js
- @tyxla WooCommerce: Remove disabled store referrers stats #60083client/my-sites/pages/page-list.jsx
- @flootrPageList
: refactor away fromUNSAFE_*
#61314client/my-sites/post-selector/selector.jsx
- @tyxla Components: Remove unusedPostSelector
component #63664client/my-sites/store/components/d3/base/index.js
- @tyxla Store: RefactorD3Base
away fromUNSAFE_
methods #63666client/my-sites/resume-editing/index.jsx
- @tyxla Editor: Remove unusedResumeEditing
component and last draft state #60295client/my-sites/site-settings/date-time-format/index.jsx
- @tyxla Site Settings: RefactorDateTimeFormat
away fromUNSAFE_
methods #63443client/my-sites/site-settings/jetpack-sync-panel/index.jsx
- @tyxla Site Settings: MigrateJetpackSyncPanel
away fromUNSAFE_
methods #58764client/my-sites/site-settings/form-jetpack-monitor.jsx
- @tyxla Site Settings: Refactor Monitor settings toreact-query
and remove UNSAFE methods #60439client/my-sites/site-settings/seo-settings/main.jsx
@flootrSeoSettingsMain
: Refactor away fromUNSAFE_*
#59107client/my-sites/site-settings/seo-settings/form.jsx
@flootr SiteSettingsSeoFrom: refactor away fromUNSAFE_cWRP
#59940client/my-sites/site-settings/seo-settings/site-verification.jsx
@flootrclient/my-sites/site-settings/wrap-settings-form.jsx
- @tyxla Settings: Refactor away fromUNSAFE_
methods inwrapSettingsForm
#60045client/my-sites/plan-features/index.jsx
- @tyxla Plans: MigratePlanFeatures
away fromUNSAFE_
methods #60389client/my-sites/marketing/buttons/tray.jsx
client/my-sites/marketing/connections/services/slack.js
client/my-sites/marketing/connections/services/instagram.jsx
client/my-sites/marketing/connections/services/google-photos.js
client/my-sites/marketing/connections/services/google-my-business.js
client/my-sites/marketing/connections/services/mailchimp.js
client/my-sites/marketing/connections/inline-connection-action.jsx
client/my-sites/marketing/connections/service.jsx
client/my-sites/preview/main.jsx
- @tyxla Preview: Refactor away fromUNSAFE_
methods #60044client/my-sites/exporter/export-card/index.jsx
- @tyxla Export: Refactor awayExportCard
fromUNSAFE_
methods #60298client/my-sites/people/people-invites/invites-list-end.jsx
- @flootrInvitesListEnd
: refactor away fromUNSAFE_*
#58907client/my-sites/people/people-invite-details/index.jsx
- @flootrPeopleInviteDetails
: refactor away fromUNSAFE_*
#59106client/my-sites/people/invite-people/index.jsx
- @flootrInvitePeople
: refactor away fromUNSAFE_*
#59118client/my-sites/theme/main.jsx
- @tyxla Themes: RefactorThemeSheet
away fromUNSAFE_
lifecycle methods #60084client/my-sites/checkout/checkout-thank-you/index.jsx
- @tyxla Checkout: RefactorCheckoutThankYou
away fromUNSAFE_
methods #62851client/my-sites/plan-features-comparison/index.jsx
- @tyxla Plans: MigratePlanFeaturesComparison
away fromUNSAFE_
methods #60387client/my-sites/purchase-product/search.jsx
- @tyxla Jetpack Search: Refactor away fromUNSAFE_
methods #59440client/my-sites/plugins/plugin.jsx
- @tyxla Plugins: MigrateSinglePlugin
away fromUNSAFE_
methods #58850client/my-sites/plugins/plugins-browser/index.jsx
- @WBerredo Turn PluginsBrowser into a functional component #59019client/my-sites/plugins/main.jsx
- @tyxla Plugins: RefactorPluginsMain
away fromUNSAFE_
methods #61571client/my-sites/plugins/plugin-upload/index.jsx
client/my-sites/plugins/plugin-automated-transfer/index.jsx
- @tyxla Plugins: Remove legacy unused components #60244client/my-sites/picker/picker.jsx
client/my-sites/woocommerce/dashboard/required-plugins-install-view.jsx
- @allilevine WooCommerce Installer: remove unused code #60784client/my-sites/domains/map-domain/index.jsx
MapDomain
: refactor away fromUNSAFE_*
#61236client/my-sites/domains/domain-search/site-redirect.jsx
SiteRedirect
: refactor away fromUNSAFE_*
#61239client/my-sites/domains/transfer-domain/index.jsx
TransferDomain
: refactor away fromUNSAFE_*
#61241client/my-sites/domains/components/form/state-select.jsx
- @tyxla Domains: RefactorStateSelect
away fromUNSAFE_
methods #60449client/my-sites/domains/domain-search/index.jsx
- @tyxla Domains: RefactorDomainSearch
away fromUNSAFE_
methods #60453client/my-sites/domains/components/domain-warnings/index.jsx
DomainWarnings
: refactor away fromUNSAFE_*
#61242client/my-sites/domains/domain-management/dns/dns-add-new.jsx
@flootrDnsAddNew
: refactor away fromUNSAFE_*
#62689client/my-sites/domains/domain-management/site-redirect/index.jsx
SiteRedirect
: refactor away fromUNSAFE_*
#62551client/my-sites/domains/domain-management/name-servers/index.jsx
- @leonardost Domains: Remove old NameServers component #62626client/my-sites/comments/comment-list/index.jsx
- @flootrCommentList
: refactor away fromUNSAFE_*
#61311client/my-sites/comments/comment/index.jsx
client/my-sites/comments/comment/comment-html-editor/add-link-dialog.jsx
- @tyxla Comments: RefactorAddLinkDialog
away fromUNSAFE_
methods #61570client/signup/steps/site-picker/site-picker-submit.jsx
@flootrclient/signup/steps/site/index.jsx
- @tyxla Signup: Refactor awaySite
step fromUNSAFE_
methods #64408client/signup/steps/rewind-migrate/index.jsx
client/signup/steps/user/index.jsx
- @jsnajdr, Signup user step: migrate away from unsafe React lifecycles #59114client/signup/steps/user/test/index.js
- @jsnajdr, Signup user step: migrate away from unsafe React lifecycles #59114client/signup/steps/clone-credentials/index.jsx
@flootrCloneCredentialsStep
: refactor away fromUNSAFE_*
#61256client/signup/steps/rewind-form-creds/index.jsx
@tyxla Rewind: RefactorRewindFormCreds
away fromUNSAFE_
methods #63133client/signup/main.jsx
client/layout/guided-tours/config-elements/continue.js
- @tyxla Guided Tours: RefactorContinue
away fromUNSAFE_
methods #61366client/layout/guided-tours/docs/patch/clean-history.patch
- @tyxla Guided Tours: FixUNSAFE_
methods in docs #61367client/layout/guided-tours/config-elements/step.tsx
- @tyxlaclient/layout/guided-tours/config-elements/quit.js
- @tyxla Guided Tours: RefactorQuit
away fromUNSAFE_
lifecycle methods #61360client/layout/guided-tours/component.jsx
- @tyxla Guided Tours: RefactorGuidedToursComponent
away fromUNSAFE_
methods #61362client/layout/masterbar/notifications.jsx
- @tyxla Masterbar: RefactorMasterbarItemNotifications
away fromUNSAFE_
methods #64079client/landing/domains/registrant-verification/index.jsx
- @tyxla WPCOM: Migratewpcom.undocumented()
registrant verification towpcom.req
#58990client/landing/domains/transfer-away-confirmation/index.jsx
- @tyxla Domains: Migrate last remainingundocumented
methods #59168client/blocks/term-tree-selector/index.jsx
- @tyxla Site Settings: RefactorTermTreeSelector
away from UNSAFE_ methods #60486client/blocks/term-tree-selector/terms.jsx
- @tyxla Site Settings: RefactorTermTreeSelector
away from UNSAFE_ methods #60486client/blocks/login/login-form.jsx
client/blocks/login/two-factor-authentication/verification-code-form.jsx
VerificationCodeForm
: refactor away fromUNSAFE_*
#61353client/blocks/video-editor/index.jsx
@flootr MediaModal: refactor video editing related cmps away fromUNSAFE_*
#62586client/blocks/conversations/list.jsx
- @tyxla Reader: RefactorConversationCommentList
away fromUNSAFE_
methods #60487client/blocks/reader-full-post/featured-image.jsx
- @tyxla Reader: RefactorFeaturedImage
away fromUNSAFE_
lifecycle methods #60915client/blocks/reader-featured-video/index.jsx
- @tyxla Reader: RefactorReaderFeaturedVideo
away fromUNSAFE_
lifecycle methods #60914client/blocks/signup-form/index.jsx
- @tyxla Signup: RefactorSignupForm
away fromUNSAFE_
methods #63089client/blocks/shortcode/frame.js
- @tyxla Media: RefactorShortcodeFrame
away fromUNSAFE_
methods #63085client/blocks/keyring-connect-button/index.js
client/blocks/user-mentions/add.jsx
@flootrclient/blocks/site-preview/index.jsx
@flootrSitePreview
: refactor away fromUNSAFE_*
#63008client/blocks/global-notice/index.js
- @tyxla Login: Cleanup social account creation state and components #60920client/blocks/image-editor/image-editor-crop.jsx
client/blocks/image-editor/index.jsx
@flootrImageEditor
: refactor away fromUNSAFE_*
#62944client/blocks/image-editor/image-editor-canvas.jsx
ImageEditorCanvas
: refactor away fromUNSAFE_*
#62946client/blocks/comments/form.jsx
@flootrPostCommentForm
: refactor away fromUNSAFE_*
#63087client/blocks/comments/post-comment-list.jsx
- @tyxla Comments: RefactorPostCommentList
away fromUNSAFE_
methods #61568apps/o2-blocks/src/todo/item.js
client/lib/keyboard-shortcuts/README.md
- @tyxla Misc: MigratecomponentWillMount
tocomponentDidMount
in READMEs #60127client/state/sharing/keyring/README.md
- @tyxla Misc: MigratecomponentWillMount
tocomponentDidMount
in READMEs #60127client/state/sharing/services/README.md
- @tyxla Misc: MigratecomponentWillMount
tocomponentDidMount
in READMEs #60127Related
No response
The text was updated successfully, but these errors were encountered: