Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn PluginsBrowser into a functional component #59019

Merged
merged 4 commits into from
Dec 14, 2021

Conversation

WBerredo
Copy link
Collaborator

@WBerredo WBerredo commented Dec 9, 2021

Changes proposed in this Pull Request

Turn PluginsBrowser into a functional component

Testing instructions

No visual change should be seen.

  1. Go to /plugins page without a selected site.
  2. Click on the breadcrumbs to see if it still works.
  3. Search for a plugin and check if the list gets filtered.
  4. Verify if clicking the Manage plugins button redirects you to /plugins/manage.
  5. Verify if clicking the Upload button redirects you to /plugins/upload.
  6. Select a site and redo the steps from 2 to 5.

Fixes #59002
Also related to #58453 by removing all lifecycle methods.

@WBerredo WBerredo self-assigned this Dec 9, 2021
@github-actions
Copy link

github-actions bot commented Dec 9, 2021

@matticbot
Copy link
Contributor

matticbot commented Dec 9, 2021

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~156 bytes removed 📉 [gzipped])

name     parsed_size           gzip_size
plugins      -1721 B  (-0.3%)     -156 B  (-0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@cpapazoglou cpapazoglou self-requested a review December 13, 2021 12:52
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 13, 2021
Copy link
Contributor

@cpapazoglou cpapazoglou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran many different scenarios and looks really good. I just noticed some nudges duplicating in the sidebar for biz / ecomm plans. Not sure if it's related to this PR
SS 2021-12-13 at 15 29 32

Also, left some minor comments.

client/my-sites/plugins/plugins-browser/index.jsx Outdated Show resolved Hide resolved
client/my-sites/plugins/plugins-browser/index.jsx Outdated Show resolved Hide resolved
@WBerredo
Copy link
Collaborator Author

WBerredo commented Dec 14, 2021

I just noticed some nudges duplicating in the sidebar for biz / ecomm plans.

I'm researching about it now. After a rebase it is not showing duplicate to me anymore. Let me know if that still happening on your site.

@WBerredo WBerredo force-pushed the update/plugins-browser-functional-component branch from 9839a01 to f6a986f Compare December 14, 2021 14:27
Copy link
Contributor

@cpapazoglou cpapazoglou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now! No more duplicate nudges 😁! 🚢

@WBerredo WBerredo merged commit 0375943 into trunk Dec 14, 2021
@WBerredo WBerredo deleted the update/plugins-browser-functional-component branch December 14, 2021 15:14
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 14, 2021
@a8ci18n
Copy link

a8ci18n commented Dec 29, 2021

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7065385

Hi @WBerredo, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:

  • Buy the best plugins
  • Now you can purchase plugins right on WordPress.com to extend your website's capabilities.

Thank you in advance!

@a8ci18n
Copy link

a8ci18n commented Jan 6, 2022

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turn Plugins Browser into a functional component
4 participants