-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn PluginsBrowser into a functional component #59019
Conversation
Link to Calypso live: https://calypso.live?image=registry.a8c.com/calypso/app:build-22338 |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~156 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
9839a01
to
f6a986f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now! No more duplicate nudges 😁! 🚢
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7065385 Hi @WBerredo, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:
Thank you in advance! |
Translation for this Pull Request has now been finished. |
Changes proposed in this Pull Request
Turn PluginsBrowser into a functional component
Testing instructions
No visual change should be seen.
/plugins
page without a selected site./plugins/manage
./plugins/upload
.Fixes #59002
Also related to #58453 by removing all lifecycle methods.