Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: Update QueryPostStats to allow querying all post stats #10397

Merged
merged 1 commit into from Jan 5, 2017

Conversation

youknowriad
Copy link
Contributor

@youknowriad youknowriad commented Jan 4, 2017

Part of #10344

In this PR, I update the QueryPostStats and the post stats redux subtree to allow retrieving ALL post stats. These stats will be used later to display a graph of post views (by days, weeks, months and years).

I also update the StatsPostPerformance to meet the last coding standards.

Testing instructions

  • Open the stats insights page
  • The "Last post summary" section should continue to display the post views count as expected.

@youknowriad youknowriad added the Stats Everything related to our analytics product at /stats/ label Jan 4, 2017
@youknowriad youknowriad self-assigned this Jan 4, 2017
@matticbot
Copy link
Contributor

@youknowriad youknowriad added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 4, 2017
 - This component was used to query numeric post stats. We can now retrieve all the desired stats
@timmyc
Copy link
Contributor

timmyc commented Jan 4, 2017

This is testing out well for me. Also looks like this logic controls thew view count in the posts card seen in the post listing. It is also working there too.

Excited to see these changes!

Copy link
Contributor

@timmyc timmyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timmyc timmyc added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 4, 2017
@youknowriad youknowriad merged commit 6429987 into master Jan 5, 2017
@youknowriad youknowriad deleted the stats/query-post-stats branch January 5, 2017 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stats Everything related to our analytics product at /stats/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants