Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daily Post Button: use public websites for mock data in tests #10538

Merged
merged 1 commit into from
Jan 11, 2017

Conversation

lancewillett
Copy link
Contributor

@lancewillett lancewillett commented Jan 10, 2017

Added in c4f8008

Files:

client/blocks/daily-post-button/test/fixtures.js
client/blocks/daily-post-button/test/index.jsx

@matticbot
Copy link
Contributor

@bluefuton bluefuton added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 11, 2017
@bluefuton
Copy link
Contributor

Well spotted @lancewillett!

Copy link
Contributor

@bluefuton bluefuton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests succeed with npm run test-client client/blocks/daily-post-button.

🚢

@bluefuton bluefuton merged commit ea3c7d1 into master Jan 11, 2017
@bluefuton bluefuton deleted the remove/private-urls branch January 11, 2017 02:10
@lancewillett lancewillett removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Reader The reader site on Calypso. [Type] Task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants