-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to run Headstart on a site through Calypso. #10542
Conversation
219296d
to
ddd1d25
Compare
@michelleweber Can we get your feedback on copy here? ❤️ |
@melchoyce, of course. Here's a revision, in which I:
We can still probably improve this a little, but wanted to present a slightly different take. _Want your site to look like the demo? Use Auto Setup to automatically apply the demo site's settings to your site. You can apply Auto Setup to your current site and keep all your posts, pages, and widgets, or use it for a fresh start and delete everything currently on your site. In both cases, placeholder text will appear on your site -- some themes need certain elements to look like the demo, so Auto Setup adds those for you. Please customize it!_ |
Thank you! 🙇 @kwight — I'll get you some design feedback this afternoon or tomorrow morning. |
Good use of I'll hold off on more feedback until you have more of a chance to build it out. Want to ping me when you want me to review? |
@michelleweber done, thanks! I've also started calling it "Theme Setup", instead of "Auto Setup" – thoughts? |
page( '/settings/general/' + activeSiteDomain ); | ||
}; | ||
|
||
const noticeText = site && isJetpack ? translate( 'This feature is currently unavailable for Jetpack sites.' ) : translate( 'This action cannot be undone.' ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternate string suggestion:
translate( 'This cannot be undone' )
— translations: 3.
As of f1b085d. Patch is also done for the Customizer link (D4018). |
Design wise seems good. I'd personally try to avoid having the yellow notice bar inside a card, but I think here it works. :y: Tiny thing, can we add a border to the thumb image to avoid the whites to wash out on the white card? Like |
Yeah, was also thinking a border and maybe changing up the theme label styles a bit: Copying the "CURRENT THEME" styling on https://calypso.live/design/: |
Good one, yes 👍 |
<ActionPanelBody> | ||
<ActionPanelTitle>{ translate( 'Theme Setup' ) }</ActionPanelTitle> | ||
<Notice status={ 'is-warning' } showDismiss={ false }> | ||
{ translate( 'This action cannot be undone.' ) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternate string suggestion:
translate( 'This cannot be undone' )
— translations: 3.
08b7a7a
to
97262a5
Compare
Cool, design notes done. When loading the URL from a cold start (so no site info available yet), I've got a pulsing placeholder for the theme screenshot. But this means both the screenshot and the current site in the sidebar are going (oh, so much throbbing). @melchoyce @folletto Is there a better way design-wise to handle this?.. |
If I'm not mistaken, the entire UI is unusable until the site loads. In that case I'd just use the skeleton-loading animation on the entire card instead of just the theme, as no action can be taken until that loads. Something like: |
Yeah, think we're just going to have to deal with excessive throbbing. |
@folletto @melchoyce That seems like a lost opportunity to me. Even though the Theme Setup UI is in-actionable until site/theme info arrives (buttons are disabled, no screenshot), at least the user can read the related text and see possible actions while waiting. Having even more throbbing with less info seems a step backward to me. Of course, I'm happy to defer to design decisions, or if it's a Calypso consistency thing – just curious of the thinking behind it :) |
It's just that skeletons usually apply to the entire block, and we tend to do the same in Calypso. I'm not entirely against it, it's just that for consistency I'd keep the loading always at card-level, not more granular than that. |
<ActionPanelBody> | ||
<ActionPanelTitle>{ translate( 'Theme Setup' ) }</ActionPanelTitle> | ||
<Notice status={ 'is-warning' } showDismiss={ false }> | ||
{ translate( 'This action cannot be undone.' ) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternate string suggestion:
translate( 'This cannot be undone' )
— translations: 3.
Good point. Simpler is better. It's 👍 for me. |
Looks good to me, too 👍 |
@michaeldcain noted that we should make it clear to the user that we're making live changes to the front-end (not just "trying out" or "previewing"). |
d172e85
to
8886ad0
Compare
<ActionPanelBody> | ||
<ActionPanelTitle>{ this.translate( 'Theme Setup' ) }</ActionPanelTitle> | ||
<Notice status={ 'is-warning' } showDismiss={ false }> | ||
{ this.translate( 'This action cannot be undone.' ) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! I've found a possible matching string that has already been translated 3 times:
translate( 'This cannot be undone' )
ES Score: 5.17
Help me improve these suggestions: react with 👎 if the suggestion doesn't make any sense, or with 👍 if it's a particularly good one (even if not implemented).
a3281d1
to
2dd21b8
Compare
custom definition since `scary` isn't supported.
`THEME_SETUP_TOGGLE_DIALOG` action.
b706fab
to
f7bcc58
Compare
Headstart is the WordPress.com feature that sets up a new site on signup according to the selected theme. This gives a new user a great start towards having their "site look like the demo".
This PR would allow "Headstart on Demand": a user can choose to have Headstart run on one of their existing sites, aiding in setup any time a user switches themes.
Beginning mockup:
Previous discussion: p6nuNy-18d-p2