Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to run Headstart on a site through Calypso. #10542

Closed
wants to merge 58 commits into from

Conversation

kwight
Copy link
Contributor

@kwight kwight commented Jan 10, 2017

Headstart is the WordPress.com feature that sets up a new site on signup according to the selected theme. This gives a new user a great start towards having their "site look like the demo".

This PR would allow "Headstart on Demand": a user can choose to have Headstart run on one of their existing sites, aiding in setup any time a user switches themes.

Beginning mockup:

screen shot 2017-01-10 at 10 27 05 am

Previous discussion: p6nuNy-18d-p2

@matticbot
Copy link
Contributor

matticbot commented Jan 10, 2017

@melchoyce
Copy link
Contributor

@michelleweber Can we get your feedback on copy here? ❤️

@michelleweber
Copy link

@melchoyce, of course. Here's a revision, in which I:

  • Took the negative out of the first sentence.
  • Took the hypen out of Setup -- it's not needed/correct in this usage.
  • Took out the "Start from scratch" because I'm not sure how that internationalizes -- if you've determined that's not an issue, feel free to add it back!
  • Tried to avoid the word "content" in favor of being more specific.
  • Tried to explain the placeholder a bit more.

We can still probably improve this a little, but wanted to present a slightly different take.

_Want your site to look like the demo? Use Auto Setup to automatically apply the demo site's settings to your site.

You can apply Auto Setup to your current site and keep all your posts, pages, and widgets, or use it for a fresh start and delete everything currently on your site. In both cases, placeholder text will appear on your site -- some themes need certain elements to look like the demo, so Auto Setup adds those for you. Please customize it!_

@melchoyce
Copy link
Contributor

Thank you! 🙇

@kwight — I'll get you some design feedback this afternoon or tomorrow morning.

@melchoyce
Copy link
Contributor

Good use of is-scary on the Set Up From Scratch button. I agree with @kathrynwp that "Set Up and Keep Content" should be on the left, and I think we should probably add is-primary to that button to further call it out as the "safer," primary option.

I'll hold off on more feedback until you have more of a chance to build it out. Want to ping me when you want me to review?

@kwight
Copy link
Contributor Author

kwight commented Jan 16, 2017

@michelleweber done, thanks! I've also started calling it "Theme Setup", instead of "Auto Setup" – thoughts?

page( '/settings/general/' + activeSiteDomain );
};

const noticeText = site && isJetpack ? translate( 'This feature is currently unavailable for Jetpack sites.' ) : translate( 'This action cannot be undone.' );
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternate string suggestion:

  • translate( 'This cannot be undone' )— translations: 3.

PR translation status page

@kwight
Copy link
Contributor Author

kwight commented Jan 16, 2017

As of f1b085d. Patch is also done for the Customizer link (D4018).

screen shot 2017-01-16 at 3 28 53 pm

screen shot 2017-01-16 at 3 33 21 pm

screen shot 2017-01-16 at 3 35 38 pm

@folletto
Copy link
Contributor

Design wise seems good. I'd personally try to avoid having the yellow notice bar inside a card, but I think here it works. :y:

Tiny thing, can we add a border to the thumb image to avoid the whites to wash out on the white card? Like border: 1px solid lighten( $gray, 30% );

@melchoyce
Copy link
Contributor

Yeah, was also thinking a border and maybe changing up the theme label styles a bit:

screen shot 2017-01-17 at 10 52 16 am

Copying the "CURRENT THEME" styling on https://calypso.live/design/:

screen shot 2017-01-17 at 10 54 22 am

@folletto
Copy link
Contributor

Good one, yes 👍

<ActionPanelBody>
<ActionPanelTitle>{ translate( 'Theme Setup' ) }</ActionPanelTitle>
<Notice status={ 'is-warning' } showDismiss={ false }>
{ translate( 'This action cannot be undone.' ) }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternate string suggestion:

  • translate( 'This cannot be undone' )— translations: 3.

PR translation status page

@kwight
Copy link
Contributor Author

kwight commented Jan 17, 2017

Cool, design notes done.

When loading the URL from a cold start (so no site info available yet), I've got a pulsing placeholder for the theme screenshot. But this means both the screenshot and the current site in the sidebar are going (oh, so much throbbing). @melchoyce @folletto Is there a better way design-wise to handle this?..

screen shot 2017-01-17 at 2 06 37 pm

@folletto
Copy link
Contributor

When loading the URL from a cold start (so no site info available yet), I've got a pulsing placeholder for the theme screenshot. But this means both the screenshot and the current site in the sidebar are going (oh, so much throbbing). @melchoyce @folletto Is there a better way design-wise to handle this?..

If I'm not mistaken, the entire UI is unusable until the site loads. In that case I'd just use the skeleton-loading animation on the entire card instead of just the theme, as no action can be taken until that loads.

Something like:

screen shot 2017-01-18 at 12 49 48

@melchoyce
Copy link
Contributor

Yeah, think we're just going to have to deal with excessive throbbing.

@kwight
Copy link
Contributor Author

kwight commented Jan 18, 2017

If I'm not mistaken, the entire UI is unusable until the site loads. In that case I'd just use the skeleton-loading animation on the entire card instead of just the theme, as no action can be taken until that loads.

@folletto @melchoyce That seems like a lost opportunity to me. Even though the Theme Setup UI is in-actionable until site/theme info arrives (buttons are disabled, no screenshot), at least the user can read the related text and see possible actions while waiting. Having even more throbbing with less info seems a step backward to me.

Of course, I'm happy to defer to design decisions, or if it's a Calypso consistency thing – just curious of the thinking behind it :)

@folletto
Copy link
Contributor

It's just that skeletons usually apply to the entire block, and we tend to do the same in Calypso. I'm not entirely against it, it's just that for consistency I'd keep the loading always at card-level, not more granular than that.

<ActionPanelBody>
<ActionPanelTitle>{ translate( 'Theme Setup' ) }</ActionPanelTitle>
<Notice status={ 'is-warning' } showDismiss={ false }>
{ translate( 'This action cannot be undone.' ) }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternate string suggestion:

  • translate( 'This cannot be undone' )— translations: 3.

PR translation status page

@kwight
Copy link
Contributor Author

kwight commented Jan 19, 2017

New card-level skeleton. I just left the p blocks full-width, as getting the image in there too meant adding a bunch more CSS to behave properly at different breakpoints.

screen shot 2017-01-18 at 4 28 04 pm

@folletto
Copy link
Contributor

I just left the p blocks full-width, as getting the image in there too meant adding a bunch more CSS to behave properly at different breakpoints.

Good point. Simpler is better.

It's 👍 for me.

@melchoyce
Copy link
Contributor

Looks good to me, too 👍

@kwight
Copy link
Contributor Author

kwight commented Jan 20, 2017

@michaeldcain noted that we should make it clear to the user that we're making live changes to the front-end (not just "trying out" or "previewing").

<ActionPanelBody>
<ActionPanelTitle>{ this.translate( 'Theme Setup' ) }</ActionPanelTitle>
<Notice status={ 'is-warning' } showDismiss={ false }>
{ this.translate( 'This action cannot be undone.' ) }
Copy link

@a8ci18n a8ci18n Jan 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! I've found a possible matching string that has already been translated 3 times:
translate( 'This cannot be undone' ) ES Score: 5.17

Help me improve these suggestions: react with 👎 if the suggestion doesn't make any sense, or with 👍 if it's a particularly good one (even if not implemented).

@kwight kwight force-pushed the add/settings-theme-setup branch 2 times, most recently from a3281d1 to 2dd21b8 Compare January 31, 2017 21:12
@matticbot matticbot added the [Size] XL Probably needs to be broken down into multiple smaller issues label Mar 6, 2017
kwight added a commit that referenced this pull request Mar 9, 2017
Part of implementing #10542 for Automattic internal testing. Will not be active until #11914 .
@kwight
Copy link
Contributor Author

kwight commented Mar 10, 2017

Replaced by:

#11762
#11802
#11803
#11806
#11812
#11914
#11925

@kwight kwight closed this Mar 10, 2017
@kwight kwight deleted the add/settings-theme-setup branch March 10, 2017 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Settings All other general site settings. [Size] XL Probably needs to be broken down into multiple smaller issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants