Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Illustrations: Replace "No Sites" drake with new illustration #14200

Merged
merged 5 commits into from
May 25, 2017

Conversation

davewhitley
Copy link
Contributor

@davewhitley davewhitley commented May 17, 2017

Wip

fixes #13044

To test, you need an account with no sites. If you are willing to test and don't have an account, message me and I can lend you my test account creds.

Removed title because uses of this image are decorative.

Before After
screen shot 2017-05-18 at 4 18 29 pm screen shot 2017-05-18 at 4 15 39 pm

@matticbot
Copy link
Contributor

@matticbot matticbot added the [Size] M Medium sized issue label May 17, 2017
@davewhitley
Copy link
Contributor Author

@folletto @kjellr

Any tips on testing this? I can't seem to get this illustration to show up for me in Calypso.

@mtias
Copy link
Member

mtias commented May 18, 2017

I suggest using this as a component instead of an asset request.

@davewhitley
Copy link
Contributor Author

White shapes removed, darkened background elements.

@davewhitley davewhitley added [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels May 18, 2017
@folletto
Copy link
Contributor

I suggest using this as a component instead of an asset request.

What do you mean?

@folletto
Copy link
Contributor

Any tips on testing this? I can't seem to get this illustration to show up for me in Calypso.

Try creating a user-only account: wordpress.com/start/account

@mtias
Copy link
Member

mtias commented May 19, 2017

I mean not doing a network request to get the svg, and just inlining it when rendering.

@roundhill
Copy link
Contributor

IE 11 (sidenote: what's up with the left side of the blue button in IE?):

screen shot 2017-05-19 at 4 01 20 pm

@davewhitley
Copy link
Contributor Author

Weird, no idea. My only guess is because it's not on a whole pixel.

screen shot 2017-05-22 at 10 02 21 am

@davewhitley davewhitley added [Status] Ready to Merge and removed [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 22, 2017
@davewhitley davewhitley force-pushed the update/no-sites-illustration branch from ae65c20 to 4802db3 Compare May 25, 2017 16:57
@davewhitley davewhitley merged commit f26d7c4 into master May 25, 2017
@davewhitley davewhitley deleted the update/no-sites-illustration branch May 25, 2017 18:15
@folletto
Copy link
Contributor

Note that this image should have been placed in illustrations, not replacing Drake, as now there's one "drake" image which is not part of the new set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace our Drake "No Sites" illustration to new style
5 participants