Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signup: DSS: Specify the homepage EN button URL to trigger AB test i2. #1470

Merged
merged 1 commit into from
Dec 10, 2015

Conversation

kwight
Copy link
Contributor

@kwight kwight commented Dec 10, 2015

This match will avoid other tests such as the bloggingu tests, but also limits us for the time being to EN users.

While the actual URL for the button has a trailing slash before the ?, both Chrome and Firefox strip that slash.

@kwight kwight added [Type] Bug [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Dynamic Screenshots (DSS) labels Dec 10, 2015
@kwight
Copy link
Contributor Author

kwight commented Dec 10, 2015

@sirbrillig for review.

@sirbrillig
Copy link
Member

LGTM.

@sirbrillig sirbrillig added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 10, 2015
kwight added a commit that referenced this pull request Dec 10, 2015
Signup: DSS: Specify the homepage EN button URL to trigger AB test i2.
@kwight kwight merged commit d4c8cae into master Dec 10, 2015
@kwight kwight deleted the fix/dss-abtest-url branch December 10, 2015 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants