Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account recovery: update account-recovery reset to use wpcom-http. #18030

Merged
merged 2 commits into from
Sep 15, 2017
Merged

Account recovery: update account-recovery reset to use wpcom-http. #18030

merged 2 commits into from
Sep 15, 2017

Conversation

jeffstieler
Copy link
Contributor

Testing Instructions:

  1. Open an incognito window and make sure you are logged out.
  2. Visit http://calypso.localhost:3000/account-recovery
  3. Use a test account info to proceed with instructions, but make sure to choose "reset by the 1. primary sms number" or "reset by the recovery sms number".
  4. Enter the received code, and you should arrive the final "New password" form.
  5. Enter a new password and click reset.
  6. Verify that you can login with the new password.

Fixes #17830.

@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=update/17830-account-recover-reset-wpcom-http

@matticbot matticbot added the [Size] L Large sized issue label Sep 14, 2017
@gwwar gwwar added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 15, 2017
alexsanford
alexsanford approved these changes Sep 15, 2017
View reviewed changes
Copy link
Contributor

@alexsanford alexsanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Code looks good. I tested the account recovery steps and it seems to work. Just a small comment in the tests, but nothing blocking 🚢

client/state/data-layer/wpcom/account-recovery/reset/test/index.js Outdated
key: 'a-super-secret-key',
password: 'my-new-password-which-I-cannot-remember',
};
resetPassword( { dispatch: dispatchSpy }, dummyAction );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this call (and the calls to handleError and handleSuccess below) be either inside the it or in a beforeEach function?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the pattern here: https://github.com/Automattic/wp-calypso/blob/master/client/state/data-layer/wpcom/me/send-verification-email/test/index.js, but I agree that this should go inside the it(). 👍

@jeffstieler jeffstieler merged commit 72d4cae into master Sep 15, 2017
@jeffstieler jeffstieler deleted the update/17830-account-recover-reset-wpcom-http branch September 15, 2017 19:36
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexsanford alexsanford alexsanford approved these changes

@gwwar gwwar Awaiting requested review from gwwar

@southp southp Awaiting requested review from southp

Assignees
No one assigned
Labels
[Size] L Large sized issue State [Type] Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeffstieler @matticbot @alexsanford @gwwar