-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a/b test for new user segment step #20369
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small recommendation regarding the designType being provided as a dependency from the about step.
@@ -109,7 +109,7 @@ export default { | |||
|
|||
about: { | |||
stepName: 'about', | |||
providesDependencies: [ 'themeSlugWithRepo', 'siteTitle' ], | |||
providesDependencies: [ 'designType', 'themeSlugWithRepo', 'siteTitle', 'surveyQuestion' ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you might also need to add designType to the call to SignupActions.submitSignupStep in the about step component.
It's pretty confusing that we pass designType around in two different ways - something we should cleanup later across all flows I think.
Good catch. Thanks @markryall. I've updated it and tested it out. Looks good except for a couple errors being thrown at the end of signup. Not sure if it's related to my code or not. Can you take a look again? |
2070d16
to
355ab71
Compare
I didn't see any errors - just a warning from 'client/signup/processing-screen/index.jsx' about assigning directly to Looks good 👍 |
This PR creates an A/B test for our new site segment screen outlined here: p5XAZ9-1Cn-p2.
Testing new user
variant
/start
either logged out or in an incognito windowsignupSiteSegmentStep
is set tovariant
control
/start
either logged out or in an incognito windowsignupSiteSegmentStep
is set tocontrol
Testing existing user
/start
logged in to an existing accountsignupSiteSegmentStep
is set tovariant
@markryall and @taggon can you take a look?