-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure the order transaction state tree. #23822
Restructure the order transaction state tree. #23822
Conversation
Hmm, I've found a weird bug when doing a manual e2e test.
Somehow the action passed to https://github.com/Automattic/wp-calypso/blob/master/client/state/data-layer/wpcom-http/utils.js#L382 has Normally |
@Automattic/payments @Automattic/i18n I've resolved the above issue in 1365c79. This PR should now work and is ready for review 🙇🏻 |
calypso should expect.
`isFetching` and `errors`.
1365c79
to
99ea650
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't feel equipped to fully review the state code, but overall:
- Code LGTM
- Works as expected
- Tests cover all changes
- No apparent regression in existing code
- Tested e2e as part of Payments: Add receipt id to the route after a successful redirect checkout. #24054 and Implement the pending checkout page. #23715
Summary
This is a follow-up task of making the best use of the newly-deployed order transaction status endpoint, following #23792 . It seems big, but it actually can be boiled down into:
fromApi()
to camelCase the keys and convert the processing status into a set of known constants.isFetching
anderrors
substate underorderTransactions
Test Plan
npm run test-client order-transactions
npm run test-client "transactions/order"