Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Payments: scaffold the checkout pending page, the 2nd attempt. #23827

Merged
merged 11 commits into from
Apr 13, 2018
Merged

Payments: scaffold the checkout pending page, the 2nd attempt. #23827

merged 11 commits into from
Apr 13, 2018

Commits on Apr 13, 2018

  1. Implement a placeholder version of <CheckoutPending> component.

    @southp
    southp committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    7d2e0e5 View commit details
    Browse the repository at this point in the history

  2. Register pending routes, /checkout/thank-you/<site>/pending/:orderId 

    to the controller.
    @southp
    southp committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    8e3fd31 View commit details
    Browse the repository at this point in the history

  3. Update the route to include parsing site path parameter

    @southp
    southp committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    3f575b0 View commit details
    Browse the repository at this point in the history

  4. Direct to different ending routes accordingly.

    @southp
    southp committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    1401cca View commit details
    Browse the repository at this point in the history

  5. update getSourcePaymentTransactionDetail() as getOrderTransaction()

    @southp
    southp committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    acf2ea1 View commit details
    Browse the repository at this point in the history

  6. Dispatch setOrderTransactionError on error.

    @southp
    southp committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    aa4f8ea View commit details
    Browse the repository at this point in the history

  7. Granularize the routing rules of the pending checkout page.

    @southp
    southp committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    41e3f88 View commit details
    Browse the repository at this point in the history

  8. showErrorNotice() need to be called after page(). Otherwise, the 

    notice would be eliminated before showing.
    @southp
    southp committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    b475c1f View commit details
    Browse the repository at this point in the history

  9. Fix the case handling for the general API error.

    @southp
    southp committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    12b3eb5 View commit details
    Browse the repository at this point in the history

  10. Update the copy according to the copy review feedbacks.

    @southp
    southp committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    7f455ed View commit details
    Browse the repository at this point in the history

  11. Redirect users back to the plan page instead of the homepage in case of 

    payment cancellation or technical errors.
    @southp
    southp committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    53b7e6a View commit details
    Browse the repository at this point in the history