Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signup: Remove no-longer used flows #26532

Merged
merged 1 commit into from Aug 8, 2018
Merged

Signup: Remove no-longer used flows #26532

merged 1 commit into from Aug 8, 2018

Conversation

mattwiebe
Copy link
Contributor

Flows that are not currently linked to or planned to be in use are removed.

Also fixes a flows test that was broken.

Fixes #6503

@mattwiebe mattwiebe added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. [Status] Needs e2e Testing labels Aug 7, 2018
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=remove/unused-signup-flows

@mattwiebe mattwiebe requested review from bisko and taggon August 7, 2018 16:16
alisterscott
alisterscott approved these changes Aug 8, 2018
View reviewed changes
Copy link
Contributor

@alisterscott alisterscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning these up and running the e2e tests against this ✅

taggon
taggon approved these changes Aug 8, 2018
View reviewed changes
Copy link
Contributor

@taggon taggon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to go. 👍

@alisterscott alisterscott added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Aug 8, 2018
@mattwiebe mattwiebe merged commit 8f3b7d5 into master Aug 8, 2018
@mattwiebe mattwiebe deleted the remove/unused-signup-flows branch August 8, 2018 19:47
@mattwiebe mattwiebe mentioned this pull request Sep 26, 2018
Merged
blowery added a commit that referenced this pull request Dec 5, 2018
@blowery
Remove creative mornings signup flow
be2cc65 
It was half removed in 8f3b7d5 / #26532
@blowery blowery mentioned this pull request Dec 5, 2018
Merged
blowery added a commit that referenced this pull request Dec 5, 2018
@blowery
Remove creative mornings signup flow (#29160)
d235bd3 
It was half removed in 8f3b7d5 / #26532
@jsnajdr jsnajdr mentioned this pull request Apr 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisterscott alisterscott alisterscott approved these changes

@taggon taggon taggon approved these changes

@bisko bisko Awaiting requested review from bisko

Assignees

@mattwiebe mattwiebe

Labels
[Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. FixTheFlows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plans: remove unused signup flows
4 participants
@mattwiebe @matticbot @alisterscott @taggon