-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post Editor: Wire up the dialog opt-in button to set the blog's editor to Gutenberg. [WIP] #27799
Conversation
That's a great PR description, thank you so much for your effort! Generated by 🚫 dangerJS |
c0f1f9a
to
b7fc25c
Compare
@dmsnell I've updated this to use an action more in-line with our API discussions today – let me know if I've headed in the wrong direction, and feel free to push if you know more details! 👍 |
client/state/action-types.js
Outdated
@@ -212,6 +212,7 @@ export const EDITOR_SAVE = 'EDITOR_SAVE'; | |||
export const EDITOR_EDIT_RAW_CONTENT = 'EDITOR_EDIT_RAW_CONTENT'; | |||
export const EDITOR_INIT_RAW_CONTENT = 'EDITOR_INIT_RAW_CONTENT'; | |||
export const EDITOR_RESET_RAW_CONTENT = 'EDITOR_RESET_RAW_CONTENT'; | |||
export const EDITOR_SET_GUTENBERG = 'EDITOR_SET_GUTENBERG'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we might want to double-check our naming here. if we are going to offer opt-out then something like EDITOR_SELECT
or EDITOR_OPT_IN
which takes a parameter specifying the editor experience might be more clear in its intent
@kwight this is going in the direction yeah that I'd expect. let's connect on Monday and check again after putting in the API having a Redux action is a good idea and probably necessary so we can adjust other UI concerns in Calypso about it. |
upcoming API work for a Gutenberg "opt-in" endpoint.
unnecessary sites schema changes.
b7fc25c
to
021393d
Compare
Replaced by #27893 . |
Upcoming API work will add an endpoint for setting a blog to use the Gutenberg editor. This PR stubs out an action to consider while the API work happens.
Testing instructions
/post/:site
and then "Learn more" in the sidebar's Gutenberg visual.TBD
.