Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Editor: Wire up the dialog opt-in button to set the blog's editor to Gutenberg. [WIP] #27799

Closed
wants to merge 10 commits into from

Conversation

kwight
Copy link
Contributor

@kwight kwight commented Oct 11, 2018

Upcoming API work will add an endpoint for setting a blog to use the Gutenberg editor. This PR stubs out an action to consider while the API work happens.

Testing instructions

  • Load /post/:site and then "Learn more" in the sidebar's Gutenberg visual.
  • In the dialog, click the "Try the new editor" button.
  • Verify a successful call to TBD.
  • Verify the test site has the correct blog sticker.

@matticbot
Copy link
Contributor

@kwight kwight requested a review from a team October 11, 2018 18:21
@kwight kwight self-assigned this Oct 11, 2018
@kwight kwight added [Feature] Post/Page Editor The editor for editing posts and pages. [Goal] Gutenberg Working towards full integration with Gutenberg labels Oct 11, 2018
@ghost
Copy link

ghost commented Oct 11, 2018

That's a great PR description, thank you so much for your effort!

Generated by 🚫 dangerJS

@kwight kwight added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Oct 11, 2018
@kwight kwight force-pushed the update/gutenberg-opt-in-dialog branch from c0f1f9a to b7fc25c Compare October 12, 2018 19:58
@kwight kwight changed the title Post Editor: Add blog sticker when user opts in to Gutenberg. Post Editor: Wire up the dialog opt-in button to set the blog's editor to Gutenberg. [WIP] Oct 12, 2018
@kwight
Copy link
Contributor Author

kwight commented Oct 12, 2018

@dmsnell I've updated this to use an action more in-line with our API discussions today – let me know if I've headed in the wrong direction, and feel free to push if you know more details! 👍

@kwight kwight added [Status] In Progress and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Oct 12, 2018
@@ -212,6 +212,7 @@ export const EDITOR_SAVE = 'EDITOR_SAVE';
export const EDITOR_EDIT_RAW_CONTENT = 'EDITOR_EDIT_RAW_CONTENT';
export const EDITOR_INIT_RAW_CONTENT = 'EDITOR_INIT_RAW_CONTENT';
export const EDITOR_RESET_RAW_CONTENT = 'EDITOR_RESET_RAW_CONTENT';
export const EDITOR_SET_GUTENBERG = 'EDITOR_SET_GUTENBERG';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might want to double-check our naming here. if we are going to offer opt-out then something like EDITOR_SELECT or EDITOR_OPT_IN which takes a parameter specifying the editor experience might be more clear in its intent

@dmsnell
Copy link
Member

dmsnell commented Oct 14, 2018

@kwight this is going in the direction yeah that I'd expect. let's connect on Monday and check again after putting in the API

having a Redux action is a good idea and probably necessary so we can adjust other UI concerns in Calypso about it.

@kwight kwight force-pushed the update/gutenberg-opt-in-dialog branch from b7fc25c to 021393d Compare October 17, 2018 00:21
@kwight
Copy link
Contributor Author

kwight commented Oct 17, 2018

Replaced by #27893 .

@kwight kwight closed this Oct 17, 2018
@kwight kwight deleted the update/gutenberg-opt-in-dialog branch October 17, 2018 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Post/Page Editor The editor for editing posts and pages. [Goal] Gutenberg Working towards full integration with Gutenberg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants