remove pragma options from .prettierrc #29403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flootr
added
[Status] Needs Review
|
There are Prettier invocations with We should remove that option from there, too. |
done in f925955 👍 |
|
from #29404 (comment) we just need to add a |
|
candidates: |
|
|
Seems like most of those should have the pragma and it was missed. Notifications and the i18n package are the current standouts. |
|
in summary, i think we can forego adding a prettier ignore and just remove the pragma requirement entirely. |
jsnajdr
approved these changes
Dec 14, 2018
There was a problem hiding this comment.
Looks good! I tried to run npm run reformat-files and everything seems to be formatted reasonably without any failures. We can do the actual reformatting in separate PRs.
I plan to upgrade us to Prettier 1.15.3 before the end of the year. We're still on 1.14.0 from July 2018. But the Prettier development has cooled down a lot this year, so there won't be too many changes.
I agree. We used to have problems with the scripts in |
* Remove prettier pragma from sass files in /assets * Remove prettier pragma from sass files in /client
matticbot
removed
the
[Status] Needs Review
This was referenced Dec 14, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Nowadays we always use Prettier regardless of the pragma options. It is that from SASS files this pragma is not removed and ends up in production css files - which is not what we want. So here's an attempt to just remove it entirely.
.prettierrcTesting instructions