Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable allowExistingUsers in concierge session upsell ab tests #30173

Merged

Conversation

travisw
Copy link
Contributor

@travisw travisw commented Jan 15, 2019

Change the showConciergeSessionUpsell and showConciergeSessionUpsellNonGSuite tests to enable allowExistingUsers.

These tests haven't been exposed to the public yet, so I think this change should be fine without updating the date.

Changes proposed in this Pull Request

  • Enable allowExistingUsers in concierge session upsell ab tests

Testing instructions

I think a visual inspection should suffice for this one.

@matticbot
Copy link
Contributor

It looks like you're updating client/lib/abtest/active-tests.js. Can you please ensure our automated e2e tests know about this change? Instructions on how to do this are available here. 🙏

@matticbot
Copy link
Contributor

@travisw travisw merged commit 1adf9f2 into master Jan 18, 2019
@travisw travisw deleted the update/open-concierge-session-tests-to-existing-users branch January 18, 2019 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants