i18n: Make texts easier to translate with fewer components #3364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akirk
added
i18n
[Feature] Purchase Management
| @@ -90,7 +88,7 @@ const RemovePurchase = React.createClass( { | |||
| <CompactCard className="remove-purchase__card" onClick={ this.openDialog }> | |||
| <a href="#"> | |||
| <Gridicon icon="trash" /> | |||
| { this.translate( 'Remove %(productName)s', { args: { productName } } ) } | |||
| { this.translate( 'Remove %(productName)s', { args: { productName: productName } } ) } | |||
There was a problem hiding this comment.
Not sure if your version already represents this through ES6 or similar.
akirk
force-pushed
the
improve/remove-purchase-texts
branch
from
5083e04
to
8571bce
Compare
| } ) | ||
| } | ||
| { ' ' } | ||
| { this.translate( 'You will not be able to reuse it again without purchasing a new subscription.', { | ||
| context: "Removal confirmation on Manage Purchase page", |
There was a problem hiding this comment.
Was the removal of this context intentional?
There was a problem hiding this comment.
Yes, it's not very useful information for a translator. A context is meant to create the ability to translate two strings differently depending on the location of the original text. This text will not appear anywhere else, so any additional information to a translator is suited well in a comment (which already exists).
akirk
force-pushed
the
improve/remove-purchase-texts
branch
2 times, most recently
from
ce46b5a
to
8cec93b
Compare
akirk
force-pushed
the
improve/remove-purchase-texts
branch
from
8cec93b
to
3a3662d
Compare
|
👍 Tested. 🚢 |
gwwar
added
[Status] Ready to Merge
and removed
[Status] Needs Review
|
Thanks @gwwar! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In these texts we have quite a few components of the form:
{{tag}}%(variable){{/tag}To a translator this is potentially very confusing text. Therefore, if a tag includes only a variable, we can make the whole thing a component:
{{variable/}}and use{ components: { variable: <tag>{ variable }</tag> } }@drewblaisdell this affects your strings at "Remove Purchase" but I have a hard time testing the strings if my approach really works. Could you please try? Thanks!