E2E: Add support for horizon testing label #34746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsessions85
added
DO NOT MERGE
[Status] Needs e2e Testing horizon
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
added 2 commits
July 18, 2019 09:40
bsessions85
changed the title
Stojdza
approved these changes
Jul 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Testing instructions
To Test, set
HORIZON_TESTS=trueand then run tests. Ensure that the steps or tests where the check has been added, pass.Another option is to re-add the horizon testing label after the PR mentioned above is merged. Ensure that the domains and sign-up tests don't fail. Currently some Gutenberg tests fail but that is because of changes on Horizon where e2e tests haven't been updated yet.