Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(formatting): Remove @format pragma from codebase (2) #37847

Merged
merged 2 commits into from
Nov 22, 2019
Merged

chore(formatting): Remove @format pragma from codebase (2) #37847

merged 2 commits into from
Nov 22, 2019

Conversation

simison
Copy link
Member

@simison simison commented Nov 22, 2019 •
edited
Loading

Follow up to #37591 where most of these were removed.

Changes proposed in this Pull Request

  • Remove the last remaining @Format pragmas from the codebase
  • A couple of jsdoc fixes

Testing instructions

  • e2es should cover this

@simison simison added Framework [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] Janitorial [Status] Needs e2e Testing labels Nov 22, 2019
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=update/remove-last-format-pragmas

@simison simison requested a review from a team November 22, 2019 07:53
jsnajdr
jsnajdr approved these changes Nov 22, 2019
View reviewed changes
Copy link
Member

@jsnajdr jsnajdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :shipit:

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@simison simison merged commit 4f4acfd into master Nov 22, 2019
@simison simison deleted the update/remove-last-format-pragmas branch November 22, 2019 08:30
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnajdr jsnajdr jsnajdr approved these changes

@blowery blowery Awaiting requested review from blowery

@sgomes sgomes Awaiting requested review from sgomes

Assignees
No one assigned
Labels
Framework [Type] Janitorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@simison @matticbot @jsnajdr