-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(formatting): Remove @format pragma from codebase #37591
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Webpack Runtime (~56 bytes removed 📉 [gzipped])
Webpack runtime for loading modules. It is included in the HTML page as an inline script. Is downloaded and parsed every time the app is loaded. App Entrypoints (~20 bytes removed 📉 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~1419 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~80 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems about right. Thanks for taking care of this! Merge pending e2e tests 👍
Still a bunch of |
FYI: I was annoyed by this, tried some sed-style removal and eventually wrote a codemod: Automattic/calypso-codemods#10 I was planning to get that merged, but was waiting on #36645. No opposition to going ahead with this, just so you're aware that there's an implemented alternative that may make this easy. |
Wasn't too bad to replace with a few regexp searches. It's unique enough that it's pretty easy to find and replace. |
A while back, we removed the need for the @Format pragma in source to enable auto-formatting with prettier. We can now remove it entirely.
9472ebd
to
da5c55a
Compare
Changes proposed in this Pull Request
Testing instructions