Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable domain step design update test for test environments #39276

Merged
merged 1 commit into from Feb 11, 2020
Merged

Enable domain step design update test for test environments #39276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions client/lib/abtest/active-tests.js
View file
Open in desktop
Expand Up @@ -156,4 +156,13 @@ export default {
defaultVariation: 'control',
allowExistingUsers: true,
},
domainStepDesignUpdates: {
datestamp: '20200205',
variations: {
variantDesignUpdates: 50,
control: 50,
},
defaultVariation: 'control',
allowExistingUsers: true,
},
};
11 changes: 10 additions & 1 deletion client/signup/steps/domains/index.jsx
View file
Open in desktop
Expand Up @@ -50,6 +50,7 @@ import { fetchUsernameSuggestion } from 'state/signup/optional-dependencies/acti
import { isSitePreviewVisible } from 'state/signup/preview/selectors';
import { hideSitePreview, showSitePreview } from 'state/signup/preview/actions';
import { abtest } from 'lib/abtest';
import config from 'config';

/**
* Style dependencies
Expand Down Expand Up @@ -121,14 +122,22 @@ class DomainsStep extends React.Component {
}

this.showTestCopy = false;
this.showDesignUpdate = false;

// Do not assign user to the test if either in the launch flow or in /start/{PLAN_SLUG} flow
if (
false !== this.props.shouldShowDomainTestCopy &&
niranjan-uma-shankar marked this conversation as resolved.
Show resolved Hide resolved
! props.isPlanStepFulfilled &&
'variantShowUpdates' === abtest( 'domainStepCopyUpdates' )
) {
this.showTestCopy = true;
if (
config.isEnabled( 'domain-step-design-update-v2' ) &&
'variantDesignUpdates' === abtest( 'domainStepDesignUpdates' )
) {
this.showDesignUpdate = true;
} else {
this.showTestCopy = true;
}
}
}

Expand Down
1 change: 1 addition & 0 deletions config/development.json
View file
Open in desktop
Expand Up @@ -53,6 +53,7 @@
"domains/kracken-ui/exact-match-filter": true,
"domains/kracken-ui/max-characters-filter": true,
"domains/kracken-ui/pagination": true,
"domain-step-design-update-v2": true,
"external-media": true,
"external-media/google-photos": true,
"external-media/free-photo-library": true,
Expand Down
1 change: 1 addition & 0 deletions config/wpcalypso.json
View file
Open in desktop
Expand Up @@ -38,6 +38,7 @@
"domains/gdpr-consent-page": true,
"domains/kracken-ui/exact-match-filter": true,
"domains/kracken-ui/pagination": true,
"domain-step-design-update-v2": true,
"external-media": true,
"external-media/google-photos": true,
"external-media/free-photo-library": true,
Expand Down