New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable domain step design update test for test environments #39276
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~110 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Async-loaded Components (~60 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works as expected. LGTM 🚢
However, I didn't inspect localStorage.ABTests
to see my assigned variation. It didn't work for me, which I think expected because the store
package doesn't always store values there. Instead, I manually logged abtest( ... )
to see the assigned variations.
Changes proposed in this Pull Request
What next
Subsequent UI updates will be built on top of this. Check below to see the referenced PRs to see all the smaller tasks that build each piece of the UI update. When all the smaller pieces are finished, then a new PR that removes the feature flag will be deployed.
Testing instructions
dev
andwpcalypso
environments, user will get assigned to a new AB test when they reach the domain step in signup flow.In dev or wpcalypso environments
Use http://calypso.localhost:3000/ URL for dev environment or https://calypso.live/?branch=add/domain-step-signup-v2-abtest for wpcalypso environment.
domainStepCopyUpdates
anddomainStepDesignUpdates
. You can verify this by typinglocalStorage.ABTests;
in your browser console.control
group ofdomainStepCopyUpdates
, no change in behaviour i.e you will see the original domain step UI.domainStepCopyUpdates
, the domain step UI will depend on the other test:control
group ofdomainStepDesignUpdates
, then you will see the new domain step UI introduced in Launch the domain step test #37661(check screenshots in that PR)domainStepDesignUpdates
, then you will see the original domain step UI.In production environment
There should be no change in behaviour since we are hiding the new AB test behind a feature flag.
To simulate the production environment, we will turn off the
domain-step-design-update-v2
feature flag in the URL.?flags=-domain-step-design-update-v2
to the hashed calypso.live link e.g: https://hash-ed3926da93141d2ed4ab69328cdf577f828561d8.calypso.live/start?flags=-domain-step-design-update-v2domainStepCopyUpdates
test and should not be assigned todomainStepDesignUpdates
.Fixes 192-gh-martech