New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Domain step test: Convert recommended badge to plan-pill #39362
Domain step test: Convert recommended badge to plan-pill #39362
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~86988 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~1233363 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~163539 bytes removed 📉 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Moment.js Locales (~6618 bytes added 📈 [gzipped])
Locale data for moment.js. Unless you are upgrading the moment.js library, changes in these chunks are suspicious. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
a22ad83
to
b70e911
Compare
ac399ac
to
213be1f
Compare
213be1f
to
36e69b4
Compare
LGTM 🚀
I assume you're referring to screen sizes and not testing in the mobile app? Here are my results to confirm.
|
Yes mobile screen size, I'll make that more explicit in future testing instructions. |
Changes proposed in this Pull Request
The next domain step test is being implemented in #39276. The test is hidden behind a feature flag. We will build individual pieces of the UI in separate PRs.
This PR:
Web
Mobile
Testing instructions
Verify that control group UI is unchanged
Control of domainStepDesignUpdates test:
Control of domainStepCopyUpdates test: