Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain step text: Modify text for the free subdomain tooltip #39499

Merged
merged 1 commit into from Feb 19, 2020

Conversation

niranjan-uma-shankar
Copy link
Contributor

@niranjan-uma-shankar niranjan-uma-shankar commented Feb 18, 2020

Changes proposed in this Pull Request

The next domain step test is being implemented in #39276. The test is hidden behind a feature flag. We will build individual pieces of the UI in separate PRs.

Screenshot 2020-02-18 at 10 11 36 AM

Screenshot 2020-02-18 at 10 11 42 AM

Testing instructions

  • Go through the signup flow /start - assign yourself to variantShowUpdates of domainStepCopyUpdates and variantDesignUpdates of domainStepDesignUpdates.

  • Verify that for the free .blog and .wordpres.com domains, the tooltip text matches the recommendations in Domain step test: Fix pricing text alignment #39393 (comment):

    • For .wordpress.com, we will say Every WordPress.com site comes with a free WordPress.com address.
    • For .blog, we will say: Every WordPress.com blog comes with a free .blog address.
  • Verify that if you click the "Learn More" link in the domain price tooltips, the domain item does not get added to cart.

Screenshot 2020-02-18 at 10 36 04 AM

  • Verify that for .app domains, clicking the "Learn more" link in the tooltip does not add domain item to cart (you can use the More Extensions button to filter by .app domains if not pointed to sandbox).

Screenshot 2020-02-18 at 10 30 34 AM

… an issue wherein clicking Learn More on the tooltip will add domain to cart
@matticbot
Copy link
Contributor

@niranjan-uma-shankar niranjan-uma-shankar self-assigned this Feb 18, 2020
@niranjan-uma-shankar niranjan-uma-shankar added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature Group] Emails & Domains Features related to email integrations and domain management. [Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. labels Feb 18, 2020
);
} else {
popoverText = translate(
'Every WordPress.com site comes with a free WordPress.com address. {{a}}Learn more{{/a}}.',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 1 times:
translate( 'Every WordPress.com site comes with a free address using a WordPress.com subdomain. {{a}}Learn more{{/a}}.' ) ES Score: 7

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~48 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
domains       +475 B  (+0.1%)      +48 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~48 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
async-load-signup-steps-domains       +475 B  (+0.2%)      +48 B  (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Member

@p-jackson p-jackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

Can also confirm that clicking "Learn More" isn't adding any domain items to the cart.

@niranjan-uma-shankar niranjan-uma-shankar merged commit db5f41b into master Feb 19, 2020
@niranjan-uma-shankar niranjan-uma-shankar deleted the update/domain-step-tooltip-free branch February 19, 2020 06:05
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Emails & Domains Features related to email integrations and domain management. [Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants