New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Domain step text: Modify text for the free subdomain tooltip #39499
Conversation
… an issue wherein clicking Learn More on the tooltip will add domain to cart
); | ||
} else { | ||
popoverText = translate( | ||
'Every WordPress.com site comes with a free WordPress.com address. {{a}}Learn more{{/a}}.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 1 times:
translate( 'Every WordPress.com site comes with a free address using a WordPress.com subdomain. {{a}}Learn more{{/a}}.' )
ES Score: 7
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~48 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~48 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢
Can also confirm that clicking "Learn More" isn't adding any domain items to the cart.
Changes proposed in this Pull Request
The next domain step test is being implemented in #39276. The test is hidden behind a feature flag. We will build individual pieces of the UI in separate PRs.
Testing instructions
Go through the signup flow /start - assign yourself to variantShowUpdates of domainStepCopyUpdates and variantDesignUpdates of domainStepDesignUpdates.
Verify that for the free .blog and .wordpres.com domains, the tooltip text matches the recommendations in Domain step test: Fix pricing text alignment #39393 (comment):
Every WordPress.com site comes with a free WordPress.com address.
Every WordPress.com blog comes with a free .blog address.
Verify that if you click the "Learn More" link in the domain price tooltips, the domain item does not get added to cart.