Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Domain step test: Set variant allocation to zero #39864

Merged
merged 1 commit into from Mar 4, 2020
Merged

Domain step test: Set variant allocation to zero #39864

merged 1 commit into from Mar 4, 2020

Conversation

niranjan-uma-shankar
Copy link
Contributor

Changes proposed in this Pull Request

Testing instructions

  • Go through the signup flow at /start.
  • At the domain step, verify that you are not assigned to domainStepDesignUpdates test.
  • Verify that you can complete signup.

@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=update/dial-domain-test-to-zero

@niranjan-uma-shankar niranjan-uma-shankar self-assigned this Mar 4, 2020
@niranjan-uma-shankar niranjan-uma-shankar added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. ABTest [Feature Group] Emails & Domains Features related to email integrations and domain management. [Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. labels Mar 4, 2020
@niranjan-uma-shankar niranjan-uma-shankar added the [Team] MarTech Used by the MarTech team. label Mar 4, 2020
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

victorespigares
victorespigares approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@victorespigares victorespigares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, followed testing instructions, all working as expected.

@niranjan-uma-shankar niranjan-uma-shankar merged commit 8eafbde into master Mar 4, 2020
@niranjan-uma-shankar niranjan-uma-shankar deleted the update/dial-domain-test-to-zero branch March 4, 2020 14:43
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorespigares victorespigares victorespigares approved these changes

Assignees

@niranjan-uma-shankar niranjan-uma-shankar

Labels
ABTest [Feature Group] Emails & Domains Features related to email integrations and domain management. [Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. [Team] MarTech Used by the MarTech team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@niranjan-uma-shankar @matticbot @victorespigares