Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: highlight credentials settings section when redirected from the site activity #40018

Merged
merged 10 commits into from
Mar 12, 2020

Conversation

keoshi
Copy link
Contributor

@keoshi keoshi commented Mar 10, 2020

Changes proposed in this Pull Request

Right now we're sending customers from the site activity to security settings in case they haven't added server credentials yet. In these scenarios, it's easy to lose focus when jumping into settings. This PR helps focusing on the section that needs attention.

Note for reviewers: this implementation was done as the smallest MVP possible. I'm aware it is very fragile, so feel free to dismiss it.

jp-credentials-highlight-v2

Testing instructions

  • Fire up this PR locally or using jurassic.ninja.
  • Connect Jetpack.
  • Go to your site activity in Calypso; e.g.: http://calypso.localhost:3000/activity-log/SITE_URL.
  • Click the top banner or the popover menu item to add server credentials.
  • Ensure the correct section is highlighted when redirected to settings.

@keoshi keoshi added Jetpack [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR Rewind [Feature] Activity Log labels Mar 10, 2020
@keoshi keoshi requested review from a team March 10, 2020 14:29
@keoshi keoshi self-assigned this Mar 10, 2020
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

matticbot commented Mar 10, 2020

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~103 bytes added 📈 [gzipped])

name               parsed_size           gzip_size
settings-security       +224 B  (+0.1%)      +79 B  (+0.1%)
stats                    +30 B  (+0.0%)      +10 B  (+0.0%)
activity                 +30 B  (+0.0%)      +10 B  (+0.0%)
settings                 +15 B  (+0.0%)       +4 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~6 bytes added 📈 [gzipped])

name                                 parsed_size           gzip_size
async-load-signup-steps-clone-point        +15 B  (+0.0%)       +6 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@enejb
Copy link
Member

enejb commented Mar 10, 2020

I left a couple of minor things but other then that this looks great! Nicely done! @keoshi

keoshi and others added 2 commits March 11, 2020 08:52
Co-Authored-By: Enej Bajgoric <enej.bajgoric@gmail.com>
Co-Authored-By: Enej Bajgoric <enej.bajgoric@gmail.com>
@keoshi
Copy link
Contributor Author

keoshi commented Mar 11, 2020

Thanks for the review and the suggestions, @enejb ! They both make a lot of sense.

Copy link
Member

@enejb enejb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected. Nicely done!

@enejb enejb added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 12, 2020
@keoshi keoshi removed the [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR label Mar 12, 2020
@keoshi keoshi merged commit 815dc5f into master Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants