-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings: highlight credentials settings section when redirected from the site activity #40018
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~103 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~6 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
I left a couple of minor things but other then that this looks great! Nicely done! @keoshi |
Co-Authored-By: Enej Bajgoric <enej.bajgoric@gmail.com>
Co-Authored-By: Enej Bajgoric <enej.bajgoric@gmail.com>
Thanks for the review and the suggestions, @enejb ! They both make a lot of sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works as expected. Nicely done!
Changes proposed in this Pull Request
Right now we're sending customers from the site activity to security settings in case they haven't added server credentials yet. In these scenarios, it's easy to lose focus when jumping into settings. This PR helps focusing on the section that needs attention.
Note for reviewers: this implementation was done as the smallest MVP possible. I'm aware it is very fragile, so feel free to dismiss it.
Testing instructions
http://calypso.localhost:3000/activity-log/SITE_URL
.