Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack Cloud: replace the credentials with a Banner when Jetpack section is enabled #43125

Merged
merged 1 commit into from
Jun 10, 2020

Conversation

rcanepa
Copy link
Contributor

@rcanepa rcanepa commented Jun 9, 2020

Changes proposed in this Pull Request

  • The goal is to remove the server credentials from the Security tab and add a Banner in its place. This Banner contains a CTA to the server credentials new location at the Jetpack tab (no yet implement).

Testing instructions

  • Run this PR with yarn start.
  • Go to http://calypso.localhost:3000/settings/security/<youSiteSlug>?flags=jetpack/features-section.
  • Verify that the server credentials aren't visible.
  • Verify that there is a Banner with a CTA that points to /settings/jetpack (broken link for the moment).
  • Go to http://calypso.localhost:3000/settings/security/<youSiteSlug>.
  • Verify that the server credentials are visible.
  • Verify that there is no Banner.

Demo

image

Fixes 1179060693083348-as-1179378358843971

@rcanepa rcanepa added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) labels Jun 9, 2020
@rcanepa rcanepa requested a review from a team June 9, 2020 21:19
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~185 bytes added 📈 [gzipped])

name               parsed_size           gzip_size
settings-security       +477 B  (+0.2%)     +185 B  (+0.3%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@cleacos cleacos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected. Without the flag, I can see the Credential block, with the flag, I see the banner.

LGTM!

@cleacos
Copy link
Contributor

cleacos commented Jun 10, 2020

I'm going to merge this, I need this change.

@cleacos cleacos merged commit f74bcb6 into master Jun 10, 2020
@cleacos cleacos deleted the add/notice-server-credentials-moved branch June 10, 2020 09:34
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 10, 2020
@keoshi
Copy link
Contributor

keoshi commented Jun 10, 2020

@rcanepa @cleacos sorry to jump in, but I want to make sure we can maintain the credentials section highlight as per #40018

@a8ci18n
Copy link

a8ci18n commented Jun 10, 2020

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/3793483

Thank you @rcanepa for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Jun 17, 2020

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants