-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack Cloud: Add In Progress Scan Section #40212
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~221 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving this because the only issue I found is the one about not localizing two strings and I believe it was on purpose.
The icon is not exactly the same we have in our design, is that intentional as well?
<h1 className="scan__header scan__header--okay">{ translate( 'Preparing to scan' ) }</h1> | ||
<ProgressBar value={ 1 } total={ 100 } color="#069E08" /> | ||
<p> | ||
Welcome to Jetpack Scan, we are taking a first look at your site now and the results will |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it intentional not to localize this string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to skip the localization of this for now.
be with you soon. | ||
</p> | ||
<p> | ||
We will send you an email once the scan completes, in the meantime feel free to continue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am skipping translation here for now so that we can get more feedback on this text before they get translated.
@@ -16,7 +16,8 @@ | |||
"jetpack-cloud/backups-restore": true, | |||
"jetpack-cloud/settings": true, | |||
"jetpack-cloud/scan": true, | |||
"jetpack-cloud/scan-history": true | |||
"jetpack-cloud/scan-history": true, | |||
"jetpack-cloud/on-demand-scan": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the idea behind this key?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes the button Scan now button show up. So that it is easier to test.
Yes I didn't to spend time now implementing the animation part just yet. |
0775948
to
c1560db
Compare
804c58e
to
f393baa
Compare
Changes proposed in this Pull Request
That shows the In Progress State.
See
![Screen Shot 2020-03-17 at 2 07 57 PM](https://user-images.githubusercontent.com/115071/76859058-d816b900-6858-11ea-9001-ebf042489eef.png)
Testing instructions
Fixes #