Update backup status views: no backup, failed backup, scheduled backup #40932

cleacos · 2020-04-08T20:09:33Z

Changes proposed in this Pull Request

Update the backup status views when:

We don't have a backup on the selected date
The backup from today is scheduled (it calculates the next expected time plus 3 hours of safety margin)
Some styles applied.

Backup scheduled:

Failed backup (copy updated):

No Backup:

Testing instructions

Apply these changes
Check the copies for the different views: Backup Failed, No Backup, Scheduled Backup
Check the expected time (the remaining hours) if you have a scheduled backup for today

You need to have a Jetpack site with a backup subscription (or a plan with it). To have a:

Failed Backup scenario: disconnect the site for one, so you'll get a failed backup. Also, you can modify the props of the component, change rewind__backup_complete_full by rewind__backup_error
No Backup scenario: cancel your subscription and after that, the system will not trigger any backup. The other case is when your backup is delayed to the next day, but it's out of your hands. Directly you can modify the props of DailyBackupStatus component, add in new propfield backup: null

Scheduled Backup scenario: If the backup for today already happened, move your time zone until reach the next day. Also, you can manipulate the props as before, select today and set the backup props to null

- Updated the copies for: failed backup, no backup. - Added a new status backup view for scheduled backup for today. - Applied some styles

matticbot · 2020-04-08T20:09:35Z

Test live: https://calypso.live/?branch=update/jetpack-cloud-backup-status-add-no-backup-view

a8ci18n · 2020-04-08T20:15:12Z

client/landing/jetpack-cloud/components/daily-backup-status/index.jsx

-				<Gridicon icon="sync" />
+			<>
+				<Gridicon icon="cloud-upload" className="daily-backup-status__gridicon-no-backup" />
+				<div className="daily-backup-status__title">{ translate( 'No backup' ) }</div>


ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 21 times:
translate( 'No backups' ) ES Score: 7

a8ci18n · 2020-04-08T20:15:13Z

client/landing/jetpack-cloud/components/daily-backup-status/index.jsx

+		const yesterday = today.subtract( 1, 'days' );
+
+		const lastBackupDay = lastBackupDate.isSame( yesterday, 'day' )
+			? translate( 'Yesterday ' )


ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 54 times:
translate( 'yesterday' ) ES Score: 15
See 1 additional suggestions in the PR translation status page

a8ci18n · 2020-04-08T20:15:14Z

client/landing/jetpack-cloud/components/daily-backup-status/index.jsx

+			<>
+				<Gridicon className="daily-backup-status__gridicon-backup-scheduled" icon="cloud-upload" />
+				<div className="daily-backup-status__static-title">
+					{ translate( 'Backup Scheduled:' ) }


ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 9 times:
translate( 'Backup Scheduled' ) ES Score: 11

enejb · 2020-04-09T09:23:53Z

Can you explain in the testing instructions How to get into the different state in order to test this PR?

enejb · 2020-04-09T09:26:02Z

Why do we say more "Backups from today" (under the contact Support button). From the second screenshot that part shouldn't be there or am I missing something. :)

client/landing/jetpack-cloud/components/daily-backup-status/index.jsx

enejb · 2020-04-09T09:35:10Z

I wasn't able to test this PR but the code so far looks good and it was easy to follow. :)

cleacos · 2020-04-09T12:26:02Z

@enejb

Can you explain in the testing instructions How to get into the different state in order to test this PR?

Updated

Why do we say more "Backups from today" (under the contact Support button). From the second screenshot that part shouldn't be there or am I missing something. :)

Yes, that is, the text shouldn't be there, but it's part of another component. In this PR: #40752 that issue is fixed.

rcoll · 2020-04-10T14:05:18Z

client/landing/jetpack-cloud/components/daily-backup-status/index.jsx

 		const backupDate = applySiteOffset( backup.activityTs, { timezone, gmtOffset } );

 		const displayDate = backupDate.format( 'L' );
 		const displayTime = backupDate.format( 'LT' );

 		return (
-			<Card className="daily-backup-status__failed">
+			<>


Neat. Had to look this up. Shorthand for Fragment. Love it.

rcoll

Looks good, tests good. Shipping.

cleacos added 3 commits April 8, 2020 20:02

Get the last available backup date

c41b8d9

Pass to DailyBackupStatus the selectedDate and the onDateChange callback

70c1b5e

Update the Backup Status for the cases: fail, no backup, scheduled

2bd600b

- Updated the copies for: failed backup, no backup. - Added a new status backup view for scheduled backup for today. - Applied some styles

cleacos added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) labels Apr 8, 2020

cleacos requested review from cbauerman and rcoll April 8, 2020 20:09

cleacos self-assigned this Apr 8, 2020

a8ci18n reviewed Apr 8, 2020

View reviewed changes

enejb reviewed Apr 9, 2020

View reviewed changes

client/landing/jetpack-cloud/components/daily-backup-status/index.jsx Outdated Show resolved Hide resolved

enejb reviewed Apr 9, 2020

View reviewed changes

client/landing/jetpack-cloud/components/daily-backup-status/index.jsx Outdated Show resolved Hide resolved

cleacos requested a review from enejb April 9, 2020 09:57

cleacos closed this Apr 9, 2020

cleacos reopened this Apr 9, 2020

matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 9, 2020

Improve the translation adding comment to it.

f731d03

cleacos added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 9, 2020

rcoll reviewed Apr 10, 2020

View reviewed changes

rcoll approved these changes Apr 10, 2020

View reviewed changes

rcoll merged commit eefde73 into master Apr 10, 2020

rcoll deleted the update/jetpack-cloud-backup-status-add-no-backup-view branch April 10, 2020 14:28

matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update backup status views: no backup, failed backup, scheduled backup #40932

Update backup status views: no backup, failed backup, scheduled backup #40932

cleacos commented Apr 8, 2020 •

edited

matticbot commented Apr 8, 2020

a8ci18n Apr 8, 2020

a8ci18n Apr 8, 2020

a8ci18n Apr 8, 2020

enejb commented Apr 9, 2020

enejb commented Apr 9, 2020

enejb commented Apr 9, 2020

cleacos commented Apr 9, 2020 •

edited

rcoll Apr 10, 2020

rcoll left a comment

Update backup status views: no backup, failed backup, scheduled backup #40932

Update backup status views: no backup, failed backup, scheduled backup #40932

Conversation

cleacos commented Apr 8, 2020 • edited

Changes proposed in this Pull Request

Testing instructions

matticbot commented Apr 8, 2020

a8ci18n Apr 8, 2020

Choose a reason for hiding this comment

a8ci18n Apr 8, 2020

Choose a reason for hiding this comment

a8ci18n Apr 8, 2020

Choose a reason for hiding this comment

enejb commented Apr 9, 2020

enejb commented Apr 9, 2020

enejb commented Apr 9, 2020

cleacos commented Apr 9, 2020 • edited

rcoll Apr 10, 2020

Choose a reason for hiding this comment

rcoll left a comment

Choose a reason for hiding this comment

cleacos commented Apr 8, 2020 •

edited

cleacos commented Apr 9, 2020 •

edited