Update BackupDelta to use the backup of the selected date and show the activity log #40752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleacos
added
[Status] Needs Review
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~72 bytes removed 📉 [gzipped]) Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
Don't render ActivityLog if we don't have rewindable activities Adapt BackupDelta to use the last backup from the selected date - Broken down the backup details snapshot into several renders - Removed the Activity Log from this component. That block is rendered now by the BackupsPage - Removed unused props and functions - Added util function to get the activities categorized based on the activities passed to it Provide to the ActivityCard the timezone and the gmtOffset of the site
cleacos
force-pushed
the
update/jetpack-cloud-backupdelta-pass-the-selected-backup
branch
from
69a5ab1
to
3e72626
Compare
|
Branch rebased. |
enejb
reviewed
Apr 10, 2020
| @@ -106,6 +76,22 @@ class BackupDelta extends Component { | |||
| ? mediaCreated.slice( 0, 2 ).concat( deletedElement ) | |||
| : mediaCreated.slice( 0, 3 ); | |||
|
|
|||
| return ( | |||
| <Fragment> | |||
cleacos
added
[Status] Needs Rebase
and removed
[Status] Needs Review
|
PR outdated |
sirreal
deleted the
update/jetpack-cloud-backupdelta-pass-the-selected-backup
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
[ HUGE ]
Styles not yet applied
Update BackupDelta to use the backup of the selected date, simplify the code and doing some clean up of the component.
getCategorizedActivitiesfunction to utils to get the activities categorized based on the activities passed to itTesting instructions