Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Home: Add a video icon beside the Free Photo Library prompt. #41829

Merged
merged 1 commit into from
May 5, 2020

Conversation

kwight
Copy link
Contributor

@kwight kwight commented May 5, 2020

Both the Mastering Gutenberg and Free Photo Library cards involve text links that open a modal to a video. The former has video icons before the links, the latter does not; this PR adds the same icon to the latter for consistency.

Before After
image image

Testing instructions

  • Go to My Home either on this branch or via the calypso.live link (any site will do).
  • Verify the video icon beside "Learn more" in the Free Photo Library card under Learn and Grow.

@kwight kwight requested a review from a team as a code owner May 5, 2020 20:01
@matticbot
Copy link
Contributor

@kwight kwight requested review from a team and removed request for a team May 5, 2020 20:02
@kwight kwight self-assigned this May 5, 2020
@kwight kwight added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] Bug [Feature] My Home The main dashboard for managing a WordPress.com site. labels May 5, 2020
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~7 bytes added 📈 [gzipped])

name  parsed_size           gzip_size
home        +13 B  (+0.0%)       +7 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@gwwar gwwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense and tests well for me @kwight, good catch.

@kwight kwight merged commit f40b7ca into master May 5, 2020
@kwight kwight deleted the add/home-photos-icon branch May 5, 2020 21:08
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] My Home The main dashboard for managing a WordPress.com site. [Type] Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants