-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates Scan page wording for states #42065
Conversation
This state is unreachable due to the UpsellSwitch component higher up in the tree.
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~73 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This looks good to me. Lets ship it! |
I don't understand what this copy is trying to communicate, and I think it creates more questions than it resolves at the moment. Let's change that! Questions to try and clarify:
|
@michelleweber - Thank you for those great questions!
It means Jetpack Scan is getting ready to take the first scan of a site.
It means that the setup finishes soon, and then the site will be scanned. If there is an issue, we will email you. @enejb, do you know if the first successful scan triggers an email as well?
If there's a threat (hack, security issue, etc.), it will update here as well as send you an email. If there's no threat, it will show here. Regardless, no user action needs to happen. |
It should but we are not there yet. |
Super helpful, thanks. I'm thinking something like: Preparing to scan |
@michelleweber - Can I propose something like:
We let users know if there are security issues after the first scan, not before. |
What kind of issues would we see at this point? And now that I'm asking -- does the actual scan start automatically when this pre-scan is done? That'd be nice to add. |
We'd see issues as in security threats such as vulnerable plugins or suspicious code. We'd also notify if the system couldn't set things up like the site is down.
Yes, we'd do an initial scan automatically. |
Thoughts?: Preparing to scan Welcome to Jetpack Scan! We're scoping out your site, setting up to do a full scan. We'll let you know if we spot any issues that might impact a scan, then start your first full scan will start. |
Alrighty! I've updated the wording and can now merge once tests pass. Thanks all! |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/3626605 Thank you @ChaosExAnima for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Changes proposed in this Pull Request
provisioning
state.unavailable
state as theScanUpsell
component covers it.Testing instructions
provisioning
.Screenshot
Fixes 1151678672052943-as-1175196271951194.