Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Scan page wording for states #42065

Merged
merged 4 commits into from
May 18, 2020
Merged

Updates Scan page wording for states #42065

merged 4 commits into from
May 18, 2020

Conversation

ChaosExAnima
Copy link
Contributor

Changes proposed in this Pull Request

  • Adds better text for the provisioning state.
  • Removes unavailable state as the ScanUpsell component covers it.

Testing instructions

  • On a site with Scan, alter the scan state to be provisioning.

Screenshot

Screen Shot 2020-05-11 at 12 18 25 PM

Fixes 1151678672052943-as-1175196271951194.

@ChaosExAnima ChaosExAnima added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) labels May 11, 2020
@ChaosExAnima ChaosExAnima requested a review from a team May 11, 2020 16:41
@ChaosExAnima ChaosExAnima self-assigned this May 11, 2020
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

matticbot commented May 11, 2020

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~73 bytes removed 📉 [gzipped])

name  parsed_size           gzip_size
scan       -527 B  (-0.2%)      -73 B  (-0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@ChaosExAnima ChaosExAnima added the [Size] M Medium sized issue label May 11, 2020
@enejb
Copy link
Member

enejb commented May 12, 2020

This looks good to me. Lets ship it!

@enejb enejb added the [Status] Needs Copy Review Add this when you'd like to get a review / feedback from the Editorial team on your PR label May 12, 2020
@michelleweber
Copy link

I don't understand what this copy is trying to communicate, and I think it creates more questions than it resolves at the moment. Let's change that! Questions to try and clarify:

  • Does "we're taking a first look" mean "we're starting the first scan," or something else?

  • Does "the results will be with you soon" mean "the results of whatever this first look is doing will be ready soon" or "the first scan will be done soon"?

  • What are these results? Where will these results be available? On this page? Will I get an email?

@ChaosExAnima
Copy link
Contributor Author

@michelleweber - Thank you for those great questions!

Does "we're taking a first look" mean "we're starting the first scan," or something else?

It means Jetpack Scan is getting ready to take the first scan of a site.

Does "the results will be with you soon" mean "the results of whatever this first look is doing will be ready soon" or "the first scan will be done soon"?

It means that the setup finishes soon, and then the site will be scanned. If there is an issue, we will email you. @enejb, do you know if the first successful scan triggers an email as well?

What are these results? Where will these results be available? On this page? Will I get an email?

If there's a threat (hack, security issue, etc.), it will update here as well as send you an email. If there's no threat, it will show here. Regardless, no user action needs to happen.

@enejb
Copy link
Member

enejb commented May 12, 2020

It means that the setup finishes soon, and then the site will be scanned. If there is an issue, we will email you. @enejb, do you know if the first successful scan triggers an email as well?

It should but we are not there yet.

@michelleweber
Copy link

Super helpful, thanks. I'm thinking something like:

Preparing to scan
Welcome to Jetpack Scan! We're scoping out your site, getting set up to take the first full scan. We'll let you know if we spot any security issues, and then your first scan will start.

@ChaosExAnima
Copy link
Contributor Author

@michelleweber - Can I propose something like:

Welcome to Jetpack Scan! We're scoping out your site, getting set up to take the first scan. We'll let you know if we spot any security issues!

We let users know if there are security issues after the first scan, not before.

@michelleweber
Copy link

It means that the setup finishes soon, and then the site will be scanned. If there is an issue, we will email you.

What kind of issues would we see at this point?

And now that I'm asking -- does the actual scan start automatically when this pre-scan is done? That'd be nice to add.

@ChaosExAnima
Copy link
Contributor Author

What kind of issues would we see at this point?

We'd see issues as in security threats such as vulnerable plugins or suspicious code. We'd also notify if the system couldn't set things up like the site is down.

And now that I'm asking -- does the actual scan start automatically when this pre-scan is done? That'd be nice to add.

Yes, we'd do an initial scan automatically.

@michelleweber
Copy link

Thoughts?:

Preparing to scan

Welcome to Jetpack Scan! We're scoping out your site, setting up to do a full scan. We'll let you know if we spot any issues that might impact a scan, then start your first full scan will start.

@ChaosExAnima
Copy link
Contributor Author

Alrighty! I've updated the wording and can now merge once tests pass. Thanks all!

@ChaosExAnima ChaosExAnima merged commit dbba54d into master May 18, 2020
@ChaosExAnima ChaosExAnima deleted the update/scan-wording branch May 18, 2020 16:45
@matticbot matticbot removed [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 18, 2020
@a8ci18n
Copy link

a8ci18n commented May 18, 2020

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/3626605

Thank you @ChaosExAnima for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Jun 4, 2020

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) [Size] M Medium sized issue [Status] Needs Copy Review Add this when you'd like to get a review / feedback from the Editorial team on your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants