-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[e2e] Add tests for launching a site #42513
Conversation
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
ea6edc0
to
3717060
Compare
@razvanpapadopol, according to #40135, did you want to add some of the new tests to canaries? |
In my opinion this would be mostly redundant, covering a large part of the flow tested already by the signup tests. What do you think about adding this step to an existing canary signup test? |
Full e2e suite is running two times every day. If you think it's enough for testing |
Yup. Just mark test with
|
Yes, but that will add the whole test preparation and cleanup as well to canaries (create account, create site, delete account) so I suggested instead to just add a single step to the complete signup flow that we already have:
here: https://github.com/Automattic/wp-calypso/blob/master/test/e2e/specs/wp-signup-spec.js#L488 |
Because it broke before :D If it's too heavy, it's fine to leave it on the full suite. |
3717060
to
1634ab2
Compare
…rchasing a domain starting from My Home. - add LaunchSiteFlow - add CreateSiteFlow
a96b759
to
b786974
Compare
@razvanpapadopol I tried failed tests locally, against WP.com and live branch, and they passed. You're good to go 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Changes proposed in this Pull Request
LaunchSiteFlow
to lib.CreateSiteFlow
to lib.Testing instructions
Fixes #40135