Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix site launch flow after switching to a new site #42516

Merged
merged 1 commit into from May 21, 2020

Conversation

razvanpapadopol
Copy link

Changes proposed in this Pull Request

  • Update RegisterDomainStep to prevent crashing when trying to launch a site after a site change.

Testing instructions

Fixes #42515
Unblocks #42513

@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

matticbot commented May 21, 2020

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~4 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
domains        +14 B  (+0.0%)       +4 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~4 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
async-load-signup-steps-domains        +14 B  (+0.0%)       +4 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@sirreal sirreal requested a review from klimeryk May 21, 2020 07:54
Copy link
Member

@sirreal sirreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to fix the cited issue. I didn't find any regressions in my testing. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Site launch flow broken after switching to a new site
3 participants