Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete @types #42584

Merged
merged 1 commit into from May 25, 2020
Merged

Remove obsolete @types #42584

merged 1 commit into from May 25, 2020

Conversation

sirreal
Copy link
Member

@sirreal sirreal commented May 22, 2020

These types are now bundled with the packages.

See DefinitelyTyped/DefinitelyTyped#44673

Testing

  • Build works
  • typecheck-strict job passes

@sirreal
Remove obsolete @types
16f4395 
These types are now bundled with the packages.

See DefinitelyTyped/DefinitelyTyped#44673
@sirreal sirreal requested a review from a team as a code owner May 22, 2020 16:11
@sirreal sirreal self-assigned this May 22, 2020
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=remove/obsolete-types

@sirreal sirreal mentioned this pull request May 22, 2020
Merged
@sirreal sirreal requested a review from ockham May 22, 2020 16:16
ockham
ockham approved these changes May 22, 2020
View reviewed changes
Copy link
Contributor

@ockham ockham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks Jon!

@sirreal sirreal merged commit ab0d88e into master May 25, 2020
@sirreal sirreal deleted the remove/obsolete-types branch May 25, 2020 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ockham ockham ockham approved these changes

@scinos scinos scinos approved these changes

Assignees

@sirreal sirreal

Labels
Build [Type] Janitorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sirreal @matticbot @ockham @scinos