Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FSE: Remove obsolete typedefs for @wordpress/icons #42576

Merged
merged 1 commit into from
May 22, 2020
Merged

FSE: Remove obsolete typedefs for @wordpress/icons #42576

merged 1 commit into from
May 22, 2020

Conversation

ockham
Copy link
Contributor

@ockham ockham commented May 22, 2020

Changes proposed in this Pull Request

Follow-up to https://github.com/Automattic/wp-calypso/pull/41703/files#r428944660.

@wordpress/icons comes with typedefs included these days.

Testing instructions

See #41703. (Do a yarn distclean first.)

@ockham ockham added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Goal] Full Site Editing labels May 22, 2020
@ockham ockham requested a review from p-jackson May 22, 2020 14:39
@ockham ockham self-assigned this May 22, 2020
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=remove/obsolete-wordpress-icons-typedefs

@matticbot
Copy link
Contributor

Caution: This PR affects files in the FSE Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D43838-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing in the FSE Plugin for more info: PCYsg-ly5-p2

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@ockham ockham requested a review from sirreal May 22, 2020 15:14
@sirreal
Copy link
Member

sirreal commented May 22, 2020

We should remove a bunch of obsolete DT packages as well:

DefinitelyTyped/DefinitelyTyped#44673

There are even more than listed in that PR now.

sirreal
sirreal approved these changes May 22, 2020
View reviewed changes
Copy link
Member

@sirreal sirreal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable… I guess this was included just because there are no files/includes/excludes in the FSE tsconfig?

@sirreal
Copy link
Member

sirreal commented May 22, 2020

We should remove a bunch of obsolete DT packages as well:

DefinitelyTyped/DefinitelyTyped#44673

There are even more than listed in that PR now.

I'm working on this but can't open a PR right now, GitHub seems to be having problems.

https://github.com/Automattic/wp-calypso/tree/remove/obsolete-types

@sirreal
Copy link
Member

sirreal commented May 22, 2020

There we go: #42584

@ockham ockham mentioned this pull request May 22, 2020
Merged
15 tasks
@ockham ockham merged commit a2fd96d into master May 22, 2020
@ockham ockham deleted the remove/obsolete-wordpress-icons-typedefs branch May 22, 2020 19:26
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirreal sirreal sirreal approved these changes

@p-jackson p-jackson Awaiting requested review from p-jackson

Assignees

@ockham ockham

Labels
[Goal] Full Site Editing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ockham @matticbot @sirreal