Media: Update media over storage limit error

[gwwar]

This PR fixes #3898 and provides a more descriptive error message when you upload a media item and are out of space. Click on the notice action "Upgrade Plan" should take you to the plans page.

Desktop

Mobile: ( Note that our notices don't handle text + action + dismiss buttons nicely )

(And here when it breaks to the next line )

Testing

• In the console call: localStorage.setItem('debug', 'calypso:analytics');
• Navigate to http://calypso.localhost:3000/post
• Select a wpcom site with a Free or Premium plan when prompted
• Add items until you run out of space. (You also have permission to use gwwartest3.wordpress.com if you're lazy )
• You should see the error notice.
• A message like the following appears in the console:
  
• Click on "Upgrade Plan"
• A message like the following appears in the console:
  
• The page should navigate to the plans page for your site.

cc @rralian @mtias @artpi @adambbecker @retrofox @aduth @apeatling

[aduth]

Aside: Kinda wish we would render a <button /> from <NoticeAction /> if we didn't want to specify a href.

[gwwar]

I agree, we can improve usage here with the NoticeAction. Forcing an href for non-external links also requires us to prevent the default action.

[aduth]

Seems that analytics related to notice display and action are common enough that, perhaps in a separate pull request, we offer enhanced notice components with this functionality baked in. Thoughts?

[aduth]

Assuming the role of my inner @apeatling ( 😄 ), do we worry that by not opening the page in a new tab, there's a feeling of uncertainty by being navigated away from the editor when clicking the call-to-action?

[aduth]

Behavior works as expected. 👍

One thing I noticed in testing - when deleting media from the media library, we don't update the storage progress bar display in the media modal. I might imagine it could be a common flow for users to "purge" unneeded media and expect to see the freed storage reflected in the progress bar.

[mtias]

Is there any other way we can handle this? Seems like a potential avenue for problematic usage.

[gwwar]

Was thinking of a more generic metrics component wrapper if we do want to track when certain components are rendered. Edit: see #4398

[gwwar]

Outstanding future improvements for future PRs

• Add a generic analytics component that counts when it's mounted. Framework: add metric for plan-storage component #4398
• Trigger refetches for storage limits whenever the flux store updates Media: fetch media limits when media list changes #4432
• Better notice action styling

I'll wait until #4398 lands before this is set back to needs review.

[aduth]

Looks good 👍

[gwwar]

Thanks for the reviews! I'm going to squash.

[apeatling]

🎉