Prevents upsell for Jetpack Backup for multisite installations

[ChaosExAnima]

Changes proposed in this Pull Request

• Adds an additional state for multisite installations to notify users that Backup is not available.
• Removes unused file wpcom-upsell.tsx in the Jetpack Cloud code.
• Fixes a bug with the Scan request code that causes a fail when threats are not an array.

Screenshots

Testing instructions

• Create a Jetpack multisite and connect it.
• With this code, visit cloud.jetpack.com and navigate to the Backup nav for the site.
• Verify Backup matches screenshot above.

Note: Jetpack Scan may not show the correct state for multisites. This is a known issue and is due to an API issue.

Fixes 1184358343400545-as-1184719508034178.

[matticbot]

Test live: https://calypso.live/?branch=fix/prevent-backup-multisite

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~154 bytes added 📈 [gzipped])

name    parsed_size           gzip_size
backup       +384 B  (+0.1%)     +114 B  (+0.1%)
scan         +341 B  (+0.1%)      +40 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~44 bytes added 📈 [gzipped])

name                                   parsed_size           gzip_size
async-load-my-sites-sidebar                 +165 B  (+0.1%)      +22 B  (+0.0%)
async-load-components-jetpack-sidebar       +165 B  (+0.8%)      +22 B  (+0.4%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[cleacos]

Should this PR work for the Jetpack (Calypso) upsells?

[ChaosExAnima]

Should this PR work for the Jetpack (Calypso) upsells?

No, as the Calypso side of things uses different components. It's a good point, and we should implement that in a different PR. :)

[rcanepa]

LGTM!

[cleacos]

It works as expected for the Backup section. One question, in the end, should the Scan section have the same/similar message for multisite?

[ChaosExAnima]

It works as expected for the Backup section. One question, in the end, should the Scan section have the same/similar message for multisite?

@cleacos whoops, should have updated the testing code. This PR applies to Scan as well!

[cleacos]

This PR applies to Scan as well!

For Scan section it didn't work, I saw the normal upsell page. @ChaosExAnima

[ChaosExAnima]

@cleacos - Yes, see the note above under the testing instructions. That is expected.

[a8ci18n]

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/4101660

Thank you @ChaosExAnima for including a screenshot in the description! This is really helpful for our translators.

[a8ci18n]

Translation for this Pull Request has now been finished.