Prevents upsell for Jetpack Backup & Scan for WP.com #44230

ChaosExAnima · 2020-07-16T17:05:40Z

Changes proposed in this Pull Request

Adds two new upsell designs mirroring the work done for cloud.jetpack.com and in Prevents upsell for Jetpack Backup for multisite installations #44187.

Screenshots

Backup - VaultPress

Backup - Multi-sites

Scan - VaultPress

Scan - Multi-Sites

Testing instructions

Create a Jetpack multisite and connect it.
With this code, visit wordpress.com and navigate to the Backup nav for the site.
Verify Backup matches the screenshot for multi-sites above.
Do the same, but with Scan.
Do the same but with a single site with VaultPress installed.
Verify Backup & Scan matches the screenshot for VaultPress above.

Note: Jetpack Scan may not show the correct state for multisites. This is a known API issue. An alternative way to test would be to set the reason prop on the WPCOMScanUpsellPage component.

Fixes 1184358343400545-as-1184719508034178.

matticbot · 2020-07-16T17:05:42Z

Test live: https://calypso.live/?branch=update/wpcom-upsell-multisites

ChaosExAnima · 2020-07-16T17:06:21Z

Hey @eeeeevon13, can you give a quick 👍 on these looks? Text is identical to what's on the cloud.

matticbot · 2020-07-16T17:16:11Z

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~1784 bytes added 📈 [gzipped])

name                  parsed_size           gzip_size
backup                    +1351 B  (+0.3%)     +240 B  (+0.2%)
scan                      +1317 B  (+0.4%)     +279 B  (+0.3%)
woocommerce                +118 B  (+0.0%)      +34 B  (+0.0%)
themes                     +118 B  (+0.0%)      +37 B  (+0.0%)
stats                      +118 B  (+0.0%)      +40 B  (+0.0%)
settings-writing           +118 B  (+0.0%)      +40 B  (+0.0%)
settings-security          +118 B  (+0.0%)      +40 B  (+0.1%)
settings-performance       +118 B  (+0.0%)      +40 B  (+0.1%)
settings-jetpack           +118 B  (+0.1%)      +46 B  (+0.1%)
settings-discussion        +118 B  (+0.1%)      +40 B  (+0.1%)
settings                   +118 B  (+0.0%)      +44 B  (+0.0%)
security                   +118 B  (+0.0%)      +37 B  (+0.0%)
purchase-product           +118 B  (+0.2%)      +35 B  (+0.2%)
posts-custom               +118 B  (+0.0%)      +40 B  (+0.0%)
posts                      +118 B  (+0.0%)      +40 B  (+0.0%)
plugins                    +118 B  (+0.0%)      +37 B  (+0.0%)
plans                      +118 B  (+0.0%)      +42 B  (+0.0%)
people                     +118 B  (+0.0%)      +40 B  (+0.0%)
pages                      +118 B  (+0.1%)      +40 B  (+0.1%)
migrate                    +118 B  (+0.1%)      +40 B  (+0.1%)
media                      +118 B  (+0.0%)      +41 B  (+0.0%)
marketing                  +118 B  (+0.0%)      +40 B  (+0.0%)
jetpack-connect            +118 B  (+0.0%)      +35 B  (+0.0%)
import                     +118 B  (+0.1%)      +37 B  (+0.1%)
hosting                    +118 B  (+0.1%)      +37 B  (+0.1%)
home                       +118 B  (+0.0%)      +40 B  (+0.0%)
export                     +118 B  (+0.1%)      +32 B  (+0.1%)
email                      +118 B  (+0.0%)      +42 B  (+0.0%)
earn                       +118 B  (+0.0%)      +38 B  (+0.1%)
domains                    +118 B  (+0.0%)      +42 B  (+0.0%)
concierge                  +118 B  (+0.0%)      +42 B  (+0.1%)
comments                   +118 B  (+0.0%)      +34 B  (+0.0%)
checkout                   +118 B  (+0.0%)      +49 B  (+0.0%)
activity                   +118 B  (+0.0%)      +44 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~1698 bytes added 📈 [gzipped])

name                                            parsed_size           gzip_size
async-load-signup-steps-user                         +118 B  (+0.1%)      +39 B  (+0.1%)
async-load-signup-steps-upsell                       +118 B  (+0.7%)      +39 B  (+0.9%)
async-load-signup-steps-theme-selection              +118 B  (+0.2%)      +36 B  (+0.2%)
async-load-signup-steps-test-step                    +118 B  (+1.5%)      +43 B  (+1.8%)
async-load-signup-steps-survey                       +118 B  (+0.7%)      +49 B  (+1.1%)
async-load-signup-steps-site-type                    +118 B  (+1.0%)      +42 B  (+1.3%)
async-load-signup-steps-site-topic                   +118 B  (+0.4%)      +43 B  (+0.5%)
async-load-signup-steps-site-title                   +118 B  (+1.0%)      +46 B  (+1.4%)
async-load-signup-steps-site-style                   +118 B  (+0.4%)      +50 B  (+0.5%)
async-load-signup-steps-site-picker                  +118 B  (+0.2%)      +40 B  (+0.2%)
async-load-signup-steps-site-or-domain               +118 B  (+0.6%)      +44 B  (+0.8%)
async-load-signup-steps-site                         +118 B  (+0.5%)      +40 B  (+0.6%)
async-load-signup-steps-rewind-were-backing          +118 B  (+1.4%)      +48 B  (+1.8%)
async-load-signup-steps-rewind-migrate               +118 B  (+0.5%)      +44 B  (+0.6%)
async-load-signup-steps-rewind-form-creds            +118 B  (+0.3%)      +49 B  (+0.4%)
async-load-signup-steps-rebrand-cities-welcome       +118 B  (+0.9%)      +45 B  (+1.2%)
async-load-signup-steps-reader-landing               +118 B  (+1.0%)      +42 B  (+1.3%)
async-load-signup-steps-plans-atomic-store           +118 B  (+0.1%)      +38 B  (+0.1%)
async-load-signup-steps-plans                        +118 B  (+0.1%)      +42 B  (+0.1%)
async-load-signup-steps-passwordless                 +118 B  (+0.5%)      +42 B  (+0.6%)
async-load-signup-steps-p2-site                      +118 B  (+0.5%)      +43 B  (+0.6%)
async-load-signup-steps-import-url-onboarding        +118 B  (+0.3%)      +37 B  (+0.3%)
async-load-signup-steps-import-url                   +118 B  (+0.5%)      +37 B  (+0.5%)
async-load-signup-steps-import-preview               +118 B  (+0.5%)      +37 B  (+0.5%)
async-load-signup-steps-domains                      +118 B  (+0.0%)      +38 B  (+0.1%)
async-load-signup-steps-creds-permission             +118 B  (+0.4%)      +44 B  (+0.5%)
async-load-signup-steps-creds-confirm                +118 B  (+0.4%)      +46 B  (+0.6%)
async-load-signup-steps-creds-complete               +118 B  (+1.4%)      +44 B  (+1.7%)
async-load-signup-steps-clone-start                  +118 B  (+0.8%)      +46 B  (+1.1%)
async-load-signup-steps-clone-ready                  +118 B  (+0.4%)      +46 B  (+0.6%)
async-load-signup-steps-clone-point                  +118 B  (+0.1%)      +39 B  (+0.1%)
async-load-signup-steps-clone-jetpack                +118 B  (+1.1%)      +46 B  (+1.6%)
async-load-signup-steps-clone-destination            +118 B  (+0.6%)      +40 B  (+0.7%)
async-load-signup-steps-clone-credentials            +118 B  (+0.2%)      +42 B  (+0.2%)
async-load-signup-steps-clone-cloning                +118 B  (+0.9%)      +43 B  (+1.1%)
async-load-signup-steps-about                        +118 B  (+0.2%)      +43 B  (+0.3%)
async-load-reader-list-manage                        +118 B  (+0.4%)      +41 B  (+0.5%)
async-load-design-playground                         +118 B  (+0.0%)      +42 B  (+0.0%)
async-load-design-blocks                             +118 B  (+0.0%)      +41 B  (+0.0%)
async-load-design                                    +118 B  (+0.0%)      +42 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

client/my-sites/scan/wpcom-scan-upsell.tsx

rcanepa

Looks and works as expected. I noticed the API bug when I visited Jetpack > Scan with a multisite, but I could see the correct version when I manually set the right reason.

cleacos

I saw the right the multisite message for the Backup section, and not for the Scan section (as the note indicated). But, how could I check the VaultPress cases, if I try to buy VaultPress, in the end I'm buying Jetpack Backup.

ChaosExAnima · 2020-07-17T14:04:52Z

@cleacos - You can set it up with the VP backend, there's a toggle. Let me know if you need details :)

a8ci18n · 2020-07-17T15:15:59Z

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/4101658

Thank you @ChaosExAnima for including a screenshot in the description! This is really helpful for our translators.

a8ci18n · 2020-07-24T09:29:01Z

Translation for this Pull Request has now been finished.

ChaosExAnima added 2 commits July 16, 2020 12:25

Fixes some typing issues.

b156b2c

Create upsell components for VP and multi-sites.

f76633e

ChaosExAnima added Jetpack [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR labels Jul 16, 2020

ChaosExAnima requested a review from a team July 16, 2020 17:05

ChaosExAnima self-assigned this Jul 16, 2020

ChaosExAnima added 2 commits July 16, 2020 15:43

Moves location of dependencies.

fc97a36

Adds Scan notices for scan upsells as well.

87efc6e

ChaosExAnima changed the title ~~Prevents upsell for Jetpack Backup for WP.com~~ Prevents upsell for Jetpack Backup & Scan for WP.com Jul 16, 2020

Change wording to protected from backed up.

ea338e0

a8ci18n reviewed Jul 16, 2020

View reviewed changes

client/my-sites/scan/wpcom-scan-upsell.tsx Outdated Show resolved Hide resolved

Changes wording to reuse translations.

836fb82

rcanepa approved these changes Jul 16, 2020

View reviewed changes

cleacos reviewed Jul 17, 2020

View reviewed changes

Fixes tests.

9c087a1

ChaosExAnima merged commit 0206947 into master Jul 17, 2020

ChaosExAnima deleted the update/wpcom-upsell-multisites branch July 17, 2020 14:39

matticbot removed [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jul 17, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prevents upsell for Jetpack Backup & Scan for WP.com #44230

Prevents upsell for Jetpack Backup & Scan for WP.com #44230

ChaosExAnima commented Jul 16, 2020 •

edited

Loading

matticbot commented Jul 16, 2020

ChaosExAnima commented Jul 16, 2020

matticbot commented Jul 16, 2020 •

edited

Loading

rcanepa left a comment

cleacos left a comment

ChaosExAnima commented Jul 17, 2020

a8ci18n commented Jul 17, 2020

a8ci18n commented Jul 24, 2020

Prevents upsell for Jetpack Backup & Scan for WP.com #44230

Prevents upsell for Jetpack Backup & Scan for WP.com #44230

Conversation

ChaosExAnima commented Jul 16, 2020 • edited Loading

Changes proposed in this Pull Request

Screenshots

Testing instructions

matticbot commented Jul 16, 2020

ChaosExAnima commented Jul 16, 2020

matticbot commented Jul 16, 2020 • edited Loading

rcanepa left a comment

Choose a reason for hiding this comment

cleacos left a comment

Choose a reason for hiding this comment

ChaosExAnima commented Jul 17, 2020

a8ci18n commented Jul 17, 2020

a8ci18n commented Jul 24, 2020

ChaosExAnima commented Jul 16, 2020 •

edited

Loading

matticbot commented Jul 16, 2020 •

edited

Loading